gh-94808: add tests covering PyFunction_GetKwDefaults and PyFunction_SetKwDefaults
#98809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
force-pushed
the
cover-pyfunction-get-set-kw-defaults
branch
from
c85132f
to
a200c39
Compare
iritkatriel
reviewed
Nov 5, 2022
Lib/test/test_capi.py
Outdated
| @@ -963,6 +977,8 @@ def some(pos_only='p', zero=0, optional=None): | |||
|
|
|||
| with self.assertRaises(SystemError): | |||
| _testcapi.function_set_defaults(some, 1) # not tuple or None | |||
There was a problem hiding this comment.
It would be good to check here that a failed set in fact did not change the defaults.
There was a problem hiding this comment.
Ah I see this is checked after the next failed set. But better to check every time.
iritkatriel
approved these changes
Nov 5, 2022
iritkatriel
added
needs backport to 3.10
iritkatriel
changed the title
PyFunction_GetKwDefaults and PyFunction_SetKwDefaultsPyFunction_GetKwDefaults and PyFunction_SetKwDefaults
|
Thanks @sobolevn for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
Sorry, @sobolevn and @iritkatriel, I could not cleanly backport this to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are also several changes to
PyFunction_[G|S]etDefaultstests:Refs: #98449