-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-95913: Consolidate build requirements changes in 3.11 WhatsNew #98781
Conversation
Co-authored-by: Petr Viktorin <[email protected]>
@encukou wrote:
Well, I chose to be extra explicit, since compilers have the bad habit of not implementing fully or exactly C standards. For example, see Modernizing Fedora's C code about GCC and clang which don't respect C99/C11 "for backward compatibility". |
Anything blocking this to be merged? |
Sorry, this PR fell through the cracks for me. I'll review this week. |
Thanks @encukou . Also, it sounds like Victor is on hiatus for now and passed on reviewing this. |
Yeah, but that (the example at least) is about keeping old behavior in cases where C99 says something is illegal or undefined. (AFAIK, the standard mandates an error, so the implementation doesn't comply with the standard, but it's fine in the real world.) |
Thanks @CAM-Gerlach for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
GH-102497 is a backport of this pull request to the 3.11 branch. |
…ew (pythonGH-98781) Apply suggestion to combine build requirements changes in 3.11 WhatsNew (cherry picked from commit 4a3ea1f) Co-authored-by: C.A.M. Gerlach <[email protected]> Co-authored-by: Petr Viktorin <[email protected]>
* main: pythongh-102493: fix normalization in PyErr_SetObject (python#102502) pythongh-87092: compiler's CFG construction moved to after codegen stage (python#102320) pythongh-95913: Consolidate build requirements changes in 3.11 WhatsNew (pythonGH-98781) Remove redundant `_ensure_future` in favor of `ensure_future` in `asyncio` (python#102398) pythongh-95913: Edit Faster CPython section in 3.11 WhatsNew (pythonGH-98429) pythongh-90110: Fix the c-analyzer Tool (python#102483) pythongh-101759: Update macOS installer SQLite 3.40.1 checksum (pythongh-102485) Remove unused import of `warnings` from `unittest.loader` (python#102479) Add gettext support to tools/extensions/c_annotations.py (python#101989)
* main: pythongh-102493: fix normalization in PyErr_SetObject (python#102502) pythongh-87092: compiler's CFG construction moved to after codegen stage (python#102320) pythongh-95913: Consolidate build requirements changes in 3.11 WhatsNew (pythonGH-98781) Remove redundant `_ensure_future` in favor of `ensure_future` in `asyncio` (python#102398) pythongh-95913: Edit Faster CPython section in 3.11 WhatsNew (pythonGH-98429) pythongh-90110: Fix the c-analyzer Tool (python#102483) pythongh-101759: Update macOS installer SQLite 3.40.1 checksum (pythongh-102485) Remove unused import of `warnings` from `unittest.loader` (python#102479) Add gettext support to tools/extensions/c_annotations.py (python#101989)
…-98781) Apply suggestion to combine build requirements changes in 3.11 WhatsNew (cherry picked from commit 4a3ea1f) Co-authored-by: C.A.M. Gerlach <[email protected]> Co-authored-by: Petr Viktorin <[email protected]>
Part of #95913 , followup to PR #98588
On #98588 , @encukou suggested several significant fixes/improvements to the Build section of the What's New in Python 3,11 document that would consolidate changes that were redundant as part of the move to C11, as well as clarify some other points. Unfortunately, the PR was merged before they could be applied there, so per his direction, I've opened this to apply them now (with a few small tweaks).