Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-98307: Add docstring and documentation for SysLogHandler.createSocket (GH-98319) #98319

Merged
merged 5 commits into from
Oct 16, 2022
Merged

gh-98307: Add docstring and documentation for SysLogHandler.createSocket (GH-98319) #98319

merged 5 commits into from
Oct 16, 2022
+21 −1

Conversation

vsajip
Copy link
Member

@vsajip vsajip commented Oct 16, 2022 •
edited by bedevere-bot
Loading

@vsajip vsajip added the docs Documentation in the Doc dir label Oct 16, 2022
@vsajip vsajip self-assigned this Oct 16, 2022
@CAM-Gerlach CAM-Gerlach added 3.11 only security fixes needs backport to 3.11 only security fixes labels Oct 16, 2022
@CAM-Gerlach CAM-Gerlach mentioned this pull request Oct 16, 2022
Closed
33 tasks
CAM-Gerlach
CAM-Gerlach reviewed Oct 16, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few tweaks. Thanks for your work and the super quick response, @vsajip !

Lib/logging/handlers.py Outdated Show resolved Hide resolved
Doc/library/logging.handlers.rst Outdated Show resolved Hide resolved
CAM-Gerlach
CAM-Gerlach approved these changes Oct 16, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @vsajip

@CAM-Gerlach
Copy link
Member

@pablogsal , please make sure to backport this if you could, so the function is documented and the links in the What's New added in #98320 work. Thanks!

@vsajip vsajip changed the title gh-98307: Add docstring and documentation for SysLogHandler.createSocket gh-98307: Add docstring and documentation for SysLogHandler.createSocket (GH-98319) Oct 16, 2022
@vsajip vsajip merged commit f6b1e40 into python:main Oct 16, 2022
@vsajip vsajip deleted the fix-98307 branch October 16, 2022 08:15
@miss-islington
Copy link
Contributor

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @vsajip, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker f6b1e4048dc353aecfbfbae07de8212900632098 3.11

vsajip added a commit to vsajip/cpython that referenced this pull request Oct 16, 2022
@vsajip
[3.11] pythongh-98307: Add docstring and documentation for SysLogHand…
489d3ed 
…ler.createSocket (pythonGH-98319)

Co-authored-by: C.A.M. Gerlach <[email protected]>
(cherry picked from commit f6b1e40)

Co-authored-by: Vinay Sajip <[email protected]>
@vsajip vsajip mentioned this pull request Oct 16, 2022
Merged
carljm added a commit to carljm/cpython that referenced this pull request Oct 17, 2022
@carljm
Merge branch 'main' into typewatch
cdbe93b 
* main: (31 commits)
  pythongh-95913: Move subinterpreter exper removal to 3.11 WhatsNew (pythonGH-98345)
  pythongh-95914: Add What's New item describing PEP 670 changes (python#98315)
  Remove unused arrange_output_buffer function from zlibmodule.c. (pythonGH-98358)
  pythongh-98174: Handle EPROTOTYPE under macOS in test_sendfile_fallback_close_peer_in_the_middle_of_receiving (python#98316)
  pythonGH-98327: Reduce scope of catch_warnings() in _make_subprocess_transport (python#98333)
  pythongh-93691: Compiler's code-gen passes location around instead of holding it on the global compiler state (pythonGH-98001)
  pythongh-97669: Create Tools/build/ directory (python#97963)
  pythongh-95534: Improve gzip reading speed by 10% (python#97664)
  pythongh-95913: Forward-port int/str security change to 3.11 What's New in main (python#98344)
  pythonGH-91415: Mention alphabetical sort ordering in the Sorting HOWTO (pythonGH-98336)
  pythongh-97930: Merge with importlib_resources 5.9 (pythonGH-97929)
  pythongh-85525: Remove extra row in doc (python#98337)
  pythongh-85299: Add note warning about entry point guard for asyncio example (python#93457)
  pythongh-97527: IDLE - fix buggy macosx patch (python#98313)
  pythongh-98307: Add docstring and documentation for SysLogHandler.createSocket (pythonGH-98319)
  pythongh-94808: Cover `PyFunction_GetCode`, `PyFunction_GetGlobals`, `PyFunction_GetModule` (python#98158)
  pythonGH-94597: Deprecate child watcher getters and setters (python#98215)
  pythongh-98254: Include stdlib module names in error messages for NameErrors (python#98255)
  Improve speed. Reduce auxiliary memory to 16.6% of the main array. (pythonGH-98294)
  [doc] Update logging cookbook with an example of custom handling of levels. (pythonGH-98290)
  ...
@hauntsaninja hauntsaninja removed the needs backport to 3.11 only security fixes label Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

Assignees

@vsajip vsajip

Labels
3.11 only security fixes docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vsajip @CAM-Gerlach @miss-islington @hauntsaninja @bedevere-bot