gh-94808: Cover str.rsplit for UCS1, UCS2 or UCS4
#98228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue about |
| @@ -445,10 +445,10 @@ def test_split(self): | |||
| def test_rsplit(self): | |||
| string_tests.CommonTest.test_rsplit(self) | |||
| # test mixed kinds | |||
| for left, right in ('ba', '\u0101\u0100', '\U00010301\U00010300'): | |||
| for left, right in ('ba', 'юё', '\u0101\u0100', '\U00010301\U00010300'): | |||
There was a problem hiding this comment.
Does this cover all of the UCS-1, UCS-2, and UCS-4 branches? Might be worth commenting on which versions are covered by which characters.
There was a problem hiding this comment.
Other places don't have comments about it, so I didn't bother adding one as well.
I believe that this does cover all unicode kinds: ba', 'юё' are UCS-1, \u0101\u0100 is UCS-2 and \U00010301\U00010300 is UCS-4
|
Thanks @sobolevn for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-98291 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 15, 2022
…8228) (cherry picked from commit b7dd2ca) Co-authored-by: Nikita Sobolev <[email protected]>
JelleZijlstra
pushed a commit
that referenced
this pull request
Oct 20, 2022
…#98291) gh-94808: Cover `str.rsplit` for UCS1, UCS2 or UCS4 (GH-98228) (cherry picked from commit b7dd2ca) Co-authored-by: Nikita Sobolev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was not covered:
Now, it is!
@vstinner I got curious and looked into other
asciilib_*calls. The setup is the same as in #98025 (comment)For example,
asciilib_rsplit_whitespacealso does not give any significant gain:./env/bin/python.exe -m pyperf timeit -v '"a b ca b d".rsplit()'I will open a new issue about where we can discuss this!