Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more syslog tests #97953

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Add more syslog tests #97953

merged 1 commit into from
Oct 7, 2022

Conversation

serhiy-storchaka
Copy link
Member

  1. It tries to cover changes in syslog issues #95041 by tests. Unfortunately it does not work for all changes, some of them cannot be tested in principle, but I hope that it can prevent similar future regressions.
  2. It includes extended version of tests proposed in gh-95011: Migrate syslog module to Argument Clinic #95012. They are worth to be backported.

@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip issue skip news needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Oct 6, 2022
@serhiy-storchaka serhiy-storchaka mentioned this pull request Oct 6, 2022
Merged
@serhiy-storchaka serhiy-storchaka merged commit cae7d1d into python:main Oct 7, 2022
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker cae7d1d7a713f8267daf5e4f2fff5cb1dad02c7c 3.11

@serhiy-storchaka serhiy-storchaka deleted the syslog-tests branch October 7, 2022 17:17
@miss-islington
Copy link
Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker cae7d1d7a713f8267daf5e4f2fff5cb1dad02c7c 3.10

@serhiy-storchaka serhiy-storchaka added needs backport to 3.10 only security fixes and removed needs backport to 3.10 only security fixes labels Oct 7, 2022
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker cae7d1d7a713f8267daf5e4f2fff5cb1dad02c7c 3.10

@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Oct 8, 2022
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker cae7d1d7a713f8267daf5e4f2fff5cb1dad02c7c 3.11

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 8, 2022
@bedevere-bot
Copy link

GH-98096 is a backport of this pull request to the 3.11 branch.

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Oct 8, 2022
@serhiy-storchaka
[3.11] Add more syslog tests (pythonGH-97953).
2090dc5 
(cherry picked from commit cae7d1d)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Oct 8, 2022
@serhiy-storchaka
[3.11] Add more syslog tests (GH-97953). (GH-98096)
f6e50b8 
(cherry picked from commit cae7d1d)
@serhiy-storchaka serhiy-storchaka removed the needs backport to 3.10 only security fixes label Oct 8, 2022
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Oct 8, 2022
@serhiy-storchaka
[3.10] Add more syslog tests (pythonGH-97953).
f382c43 
(cherry picked from commit cae7d1d)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Oct 8, 2022
@serhiy-storchaka
[3.10] Add more syslog tests (pythonGH-97953).
5867ece 
(cherry picked from commit cae7d1d)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Oct 9, 2022
@serhiy-storchaka
[3.10] Add more syslog tests (GH-97953). (GH-98101)
4d7d91f 
(cherry picked from commit cae7d1d)
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
@serhiy-storchaka @mpage
Add more syslog tests (pythonGH-97953)
bdf0373
@hauntsaninja hauntsaninja mentioned this pull request Oct 12, 2022
Closed
@serhiy-storchaka serhiy-storchaka removed their assignment Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serhiy-storchaka @miss-islington @bedevere-bot @JelleZijlstra