Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in bltinmodule.c #97766

Merged
merged 2 commits into from
Oct 3, 2022
Merged

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Oct 3, 2022

This can even break some rst formatter / pretty-printer because of invalid rst markup.

No news / issue is needed for this, I guess :)

@sobolevn sobolevn changed the title Fix typos in bltnsmodule.c Fix typos in bltinmodule.c Oct 3, 2022
@kumaraditya303
Copy link
Contributor

Clinic regen should fix the CI.

@JelleZijlstra
Copy link
Member

Screen Shot 2022-10-03 at 9 50 04 AM

The current text indeed leads to bad formatting in VSCode.

@benjaminp benjaminp added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Oct 3, 2022
@benjaminp benjaminp merged commit 873a2f2 into python:main Oct 3, 2022
@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @sobolevn and @benjaminp, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 873a2f25272ca9fb027866a9730c44ba627b30cc 3.11

@miss-islington
Copy link
Contributor

Sorry @sobolevn and @benjaminp, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 873a2f25272ca9fb027866a9730c44ba627b30cc 3.10

benjaminp pushed a commit that referenced this pull request Oct 3, 2022
(cherry picked from commit 873a2f2)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 3, 2022
@bedevere-bot
Copy link

GH-97789 is a backport of this pull request to the 3.11 branch.

@benjaminp benjaminp removed the needs backport to 3.10 only security fixes label Oct 3, 2022
carljm added a commit to carljm/cpython that referenced this pull request Oct 3, 2022
* main: (2069 commits)
  pythongh-96512: Move int_max_str_digits setting to PyConfig (python#96944)
  pythongh-94808: Coverage: Check picklablability of calliter (python#95923)
  pythongh-94808: Add test coverage for PyObject_HasAttrString (python#96627)
  pythongh-94732: Fix KeyboardInterrupt race in asyncio run_forever() (python#97765)
  Fix typos in `bltinmodule.c`. (pythonGH-97766)
  pythongh-94808: `_PyLineTable_StartsLine` was not used (pythonGH-96609)
  pythongh-97681: Remove Tools/demo/ directory (python#97682)
  Fix typo in unittest docs (python#97742)
  pythongh-97728: Argument Clinic: Fix uninitialized variable in the Py_UNICODE converter (pythonGH-97729)
  pythongh-95913: Fix PEP number in PEP 678 What's New ref label (python#97739)
  pythongh-95913: Copyedit/improve New Modules What's New section (python#97721)
  pythongh-97740: Fix bang in Sphinx C domain ref target syntax (python#97741)
  pythongh-96819: multiprocessing.resource_tracker: check if length of pipe write <= 512 (python#96890)
  pythongh-97706: multiprocessing tests: Delete unused variable `rand` (python#97707)
  pythonGH-85447: Clarify docs about awaiting future multiple times (python#97738)
  [docs] Update logging cookbook with recipe for using a logger like an output… (pythonGH-97730)
  pythongh-97607: Fix content parsing in the impl-detail reST directive (python#97652)
  pythongh-95975: Move except/*/finally ref labels to more precise locations (python#95976)
  pythongh-97591: In `Exception.__setstate__()` acquire strong references before calling `tp_hash` slot (python#97700)
  pythongh-95588: Drop the safety claim from `ast.literal_eval` docs. (python#95919)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants