-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-97670: Remove sys.getdxp() and analyze_dxp.py script #97671
Conversation
@markshannon: Would you mind to review this PR? |
@brandtbucher: Would you mind to review this PR? |
Removing the script seems fine. |
I just searched in the PyPI top 5000 projects: I found 0 projects using |
@smontanaro: I found a script using # Copyright (c) 2001-2004 Twisted Matrix Laboratories.
# See LICENSE for details.
(...)
def report(email, appname):
"""
Send an RLE encoded version of sys.getdxp() off to our Top Men (tm)
for analysis.
"""
if hasattr(sys, 'getdxp') and appname:
dxp = xmlrpclib.ServerProxy("http://manatee.mojam.com:7304")
dxp.add_dx_info(appname, email, sys.version_info[:3], rle(sys.getdxp())) See twisted/python/dxprofile.py for the full source with the This script was part of Twisted and was removed in Twisted Core 8.0.0 (2008-03-17) because it no longer worked (issue #2908). |
I found references to getdxp() by @smontanaro on python-dev mailing list in 2001-2003: |
Ah by the way, as you can see in this PR, |
@vstinner As you might have expected, I'm no longer using the dxp stuff, but thanks for checking. :-) |
Remove the sys.getdxp() function and the Tools/scripts/analyze_dxp.py script. DXP stands for "dynamic execution pairs". They were related to DYNAMIC_EXECUTION_PROFILE and DXPAIRS macros which have been removed in Python 3.11. Python can now be built with "./configure --enable-pystats" to gather statistics on Python opcodes.
Thanks for reviews. It's now removed. |
Remove the sys.getdxp() function and the Tools/scripts/analyze_dxp.py script. DXP stands for "dynamic execution pairs". They were related to DYNAMIC_EXECUTION_PROFILE and DXPAIRS macros which have been removed in Python 3.11. Python can now be built with "./configure --enable-pystats" to gather statistics on Python opcodes.