gh-94808: Cover LOAD_GLOBAL for custom dict subtypes
#96767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdboom
approved these changes
Sep 12, 2022
iritkatriel
reviewed
Nov 3, 2022
Lib/test/test_builtin.py
Outdated
| def __getitem__(self, key): | ||
| raise setonlyerror | ||
|
|
||
| class customdict(dict): # this one should not do anything fancy |
There was a problem hiding this comment.
This should be defined just before the test that uses it (below). Ideally this function would be broken up - it's testing a lot of things.
iritkatriel
approved these changes
Nov 4, 2022
iritkatriel
added
needs backport to 3.10
|
Thanks @sobolevn for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 4, 2022
…H-96767) (cherry picked from commit 044bcc1) Co-authored-by: Nikita Sobolev <[email protected]>
|
Sorry, @sobolevn and @iritkatriel, I could not cleanly backport this to |
|
GH-99091 is a backport of this pull request to the 3.11 branch. |
iritkatriel
pushed a commit
that referenced
this pull request
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've covered several missing conditions in
TARGET(LOAD_GLOBAL):globals()dict subtype raises nonKeyError:cpython/Python/ceval.c
Lines 2445 to 2447 in 53a54b7
__builtins__dict subtype raises nonKeyError:cpython/Python/ceval.c
Line 2458 in 53a54b7
NameErrorin a custom__builtins__dict subtype:cpython/Python/ceval.c
Lines 2453 to 2457 in 53a54b7