-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-96288: Add a sentence to os.mkdir
's docstring.
#96271
Conversation
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is editing the docstring in generated output.
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
os.mkdir
's docstring.os.mkdir
's docstring.
The change looks good (sorry for the wait!) but there's a merge conflict in the AC output. Could you merge main in and re-generate the AC output file? |
Thanks @hagai-helman for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
Sorry, @hagai-helman and @JelleZijlstra, I could not cleanly backport this to |
Sorry @hagai-helman and @JelleZijlstra, I had trouble checking out the |
…honGH-96271). (cherry picked from commit 1523c9e) Co-authored-by: Hagai Helman Tov <[email protected]>
GH-98065 is a backport of this pull request to the 3.11 branch. |
GH-98066 is a backport of this pull request to the 3.10 branch. |
…honGH-96271). (cherry picked from commit 1523c9e) Co-authored-by: Hagai Helman Tov <[email protected]>
#98066) (cherry picked from commit 1523c9e) Co-authored-by: Hagai Helman Tov <[email protected]>
#98065) (cherry picked from commit 1523c9e) Co-authored-by: Hagai Helman Tov <[email protected]>
* main: (38 commits) pythongh-92886: make test_ast pass with -O (assertions off) (pythonGH-98058) pythongh-92886: make test_coroutines pass with -O (assertions off) (pythonGH-98060) pythongh-57179: Add note on symlinks for os.walk (python#94799) pythongh-94808: Fix regex on exotic platforms (python#98036) pythongh-90085: Remove vestigial -t and -c timeit options (python#94941) pythonGH-83901: Improve Signature.bind error message for missing keyword-only params (python#95347) pythongh-61105: Add default param, note on using cookiejar subclass (python#95427) pythongh-96288: Add a sentence to `os.mkdir`'s docstring. (python#96271) pythongh-96073: fix backticks in NEWS entry (pythonGH-98056) pythongh-92886: [clinic.py] raise exception on invalid input instead of assertion (pythonGH-98051) pythongh-97997: Add col_offset field to tokenizer and use that for AST nodes (python#98000) pythonGH-88968: Reject socket that is already used as a transport (python#98010) pythongh-96346: Use double caching for re._compile() (python#96347) pythongh-91708: Revert params note in urllib.parse.urlparse table (python#96699) pythongh-96265: Fix some formatting in faq/design.rst (python#96924) pythongh-73196: Add namespace/scope clarification for inheritance section (python#92840) pythongh-97646: Change `.js` and `.mjs` files mimetype to conform to RFC 9239 (python#97934) pythongh-97923: Always run Ubuntu SSL tests with others in CI (python#97940) pythongh-97956: Mention `generate_global_objects.py` in `AC How-To` (python#97957) pythongh-96959: Update HTTP links which are redirected to HTTPS (python#98039) ...
A clarification about the use of umask (copied from the
os
module documentation) is added to the docstring ofos.mkdir
.The behavior described may be unexpected for some (for example, this is not the behavior of GNU's
mkdir
command - when a mode is explicitly given to it, it overrides the umask). When one is unaware of this behavior, it can lead to bugs that are difficult to notice or trace. For these two reasons, I suggest it is mentioned in the docstring.os.mkdir
should mention the effect of umask #96288