-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-96005: Handle WASI ENOTCAPABLE in getpath (GH-96006) #96006
Conversation
- On WASI `ENOTCAPABLE` is now mapped to `PermissionError`. - The `errno` modules exposes the new error number. - `getpath.py` now ignores `PermissionError` when it cannot open landmark files `pybuilddir.txt` and `pyenv.cfg`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@pablogsal RM, is this an acceptable change for 3.11.0, should I delay it for 3.11.1, or only apply it to 3.12? |
This is likely too big for 3.11.0 :( are you ok delaying this to 3.11.1? |
Sure, no problem! I'll update the docs. |
Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
- On WASI `ENOTCAPABLE` is now mapped to `PermissionError`. - The `errno` modules exposes the new error number. - `getpath.py` now ignores `PermissionError` when it cannot open landmark files `pybuilddir.txt` and `pyenv.cfg`. (cherry picked from commit 48174fa) Co-authored-by: Christian Heimes <[email protected]>
GH-96032 is a backport of this pull request to the 3.11 branch. |
|
@tiran That looks like a genuine failure |
Will investigate later |
) (GH-96038) - On WASI `ENOTCAPABLE` is now mapped to `PermissionError`. - The `errno` modules exposes the new error number. - `getpath.py` now ignores `PermissionError` when it cannot open landmark files `pybuilddir.txt` and `pyenv.cfg`.
ENOTCAPABLE
is now mapped toPermissionError
.errno
modules exposes the new error number.getpath.py
now ignoresPermissionError
when it cannot open landmarkfiles
pybuilddir.txt
andpyenv.cfg
.