Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-94808: Improve coverage of _PyBytes_FormatEx #95895

Merged

Conversation

mdboom
Copy link
Contributor

@mdboom mdboom commented Aug 11, 2022

There were two specific areas not covered:

  • %(name) syntax
  • %*s syntax

Automerge-Triggered-By: GH:iritkatriel

There were two specific areas not covered:

- %(name) syntax
- %*s syntax
@mdboom mdboom force-pushed the coverage-bytesobject-PyBytes_FormatEx branch from d3efc12 to d301fc3 Compare August 11, 2022 17:38
Copy link
Member

@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@miss-islington
Copy link
Contributor

Status check is done, and it's a success ✅.

@miss-islington miss-islington merged commit dde15f5 into python:main Sep 7, 2022
@miss-islington
Copy link
Contributor

Thanks @mdboom for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 7, 2022
There were two specific areas not covered:

- %(name) syntax
- %*s syntax

Automerge-Triggered-By: GH:iritkatriel
(cherry picked from commit dde15f5)

Co-authored-by: Michael Droettboom <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 7, 2022
@bedevere-bot
Copy link

GH-96647 is a backport of this pull request to the 3.11 branch.

miss-islington added a commit that referenced this pull request Sep 7, 2022
There were two specific areas not covered:

- %(name) syntax
- %*s syntax

Automerge-Triggered-By: GH:iritkatriel
(cherry picked from commit dde15f5)

Co-authored-by: Michael Droettboom <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants