-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-94808: Improve coverage of _PyBytes_FormatEx #95895
Merged
miss-islington
merged 2 commits into
python:main
from
mdboom:coverage-bytesobject-PyBytes_FormatEx
Sep 7, 2022
Merged
gh-94808: Improve coverage of _PyBytes_FormatEx #95895
miss-islington
merged 2 commits into
python:main
from
mdboom:coverage-bytesobject-PyBytes_FormatEx
Sep 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two specific areas not covered: - %(name) syntax - %*s syntax
mdboom
force-pushed
the
coverage-bytesobject-PyBytes_FormatEx
branch
from
August 11, 2022 17:38
d3efc12
to
d301fc3
Compare
iritkatriel
approved these changes
Sep 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Status check is done, and it's a success ✅. |
Thanks @mdboom for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 7, 2022
There were two specific areas not covered: - %(name) syntax - %*s syntax Automerge-Triggered-By: GH:iritkatriel (cherry picked from commit dde15f5) Co-authored-by: Michael Droettboom <[email protected]>
GH-96647 is a backport of this pull request to the 3.11 branch. |
miss-islington
added a commit
that referenced
this pull request
Sep 7, 2022
There were two specific areas not covered: - %(name) syntax - %*s syntax Automerge-Triggered-By: GH:iritkatriel (cherry picked from commit dde15f5) Co-authored-by: Michael Droettboom <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two specific areas not covered:
Automerge-Triggered-By: GH:iritkatriel