Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-95349: Hide a Distutils Warning Filter for test_check_c_globals #95837

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Aug 9, 2022

Under certain build conditions, test_check_c_globals fails. This fix takes the same approach as we took for gh-84236 (via gh-20095). We'll be removing use of distutils in the c-analyzer at some point. Until then we'll hide the warning filter.

Automerge-Triggered-By: GH:ericsnowcurrently

@miss-islington
Copy link
Contributor

Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 9, 2022
…als (pythonGH-95837)

Under certain build conditions, test_check_c_globals fails.  This fix takes the same approach as we took for pythongh-84236 (via pythongh-20095).  We'll be removing use of distutils in the c-analyzer at some point.  Until then we'll hide the warning filter.
(cherry picked from commit 3ff6d9a)

Co-authored-by: Eric Snow <[email protected]>
@bedevere-bot
Copy link

GH-95843 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 9, 2022
@ericsnowcurrently ericsnowcurrently deleted the fix-95349-c-analyzer-distutils-warning branch August 9, 2022 23:05
ambv pushed a commit that referenced this pull request Aug 10, 2022
…H-95837) (GH-95843)

Under certain build conditions, test_check_c_globals fails.  This fix takes the same approach as we took for gh-84236 (via gh-20095).  We'll be removing use of distutils in the c-analyzer at some point.  Until then we'll hide the warning filter.
(cherry picked from commit 3ff6d9a)

Co-authored-by: Eric Snow <[email protected]>
@zooba zooba added the needs backport to 3.10 only security fixes label Aug 10, 2022
@miss-islington
Copy link
Contributor

Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@zooba
Copy link
Member

zooba commented Aug 10, 2022

Sorry, this applies to 3.10 as well, so one more backport

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Aug 10, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 10, 2022
…als (pythonGH-95837)

Under certain build conditions, test_check_c_globals fails.  This fix takes the same approach as we took for pythongh-84236 (via pythongh-20095).  We'll be removing use of distutils in the c-analyzer at some point.  Until then we'll hide the warning filter.
(cherry picked from commit 3ff6d9a)

Co-authored-by: Eric Snow <[email protected]>
@bedevere-bot
Copy link

GH-95864 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit that referenced this pull request Aug 11, 2022
…H-95837)

Under certain build conditions, test_check_c_globals fails.  This fix takes the same approach as we took for gh-84236 (via gh-20095).  We'll be removing use of distutils in the c-analyzer at some point.  Until then we'll hide the warning filter.
(cherry picked from commit 3ff6d9a)

Co-authored-by: Eric Snow <[email protected]>
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Aug 11, 2022
…als (pythonGH-95837)

Under certain build conditions, test_check_c_globals fails.  This fix takes the same approach as we took for pythongh-84236 (via pythongh-20095).  We'll be removing use of distutils in the c-analyzer at some point.  Until then we'll hide the warning filter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants