Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-93649: Split unicode tests from _testcapimodule.c & add some more #95819

Merged
merged 6 commits into from
Aug 10, 2022

Conversation

encukou
Copy link
Member

@encukou encukou commented Aug 9, 2022

  • Move PyUnicode tests to a separate file
  • Add some more tests for PyUnicode_FromFormat

This is the refactoring & tests for existing functionality from #95505, leaving the change (and its tests) for another PR.

In addition to the changes in #95505, I made CHECK_FORMAT_* to check for SystemError when it gets NULL as the expected result. Some tests need that, as the behavior changed in #95784.

@encukou encukou requested a review from a team as a code owner August 9, 2022 12:37
@encukou encukou added skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Aug 9, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @encukou for commit 995e666 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 9, 2022
@encukou encukou merged commit 325ae93 into python:main Aug 10, 2022
@encukou encukou deleted the split-unicode-tests branch August 10, 2022 07:10
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Aug 11, 2022
… more (pythonGH-95819)

- Move PyUnicode tests to a separate file
- Add some more tests for PyUnicode_FromFormat

Co-authored-by: philg314 <[email protected]>
@serhiy-storchaka serhiy-storchaka added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Nov 29, 2022
@miss-islington
Copy link
Contributor

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @encukou, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 325ae93b6b7113cd4a4c2ce441615ae7def779e2 3.11

@miss-islington
Copy link
Contributor

Sorry @encukou, I had trouble checking out the 3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 325ae93b6b7113cd4a4c2ce441615ae7def779e2 3.10

@serhiy-storchaka
Copy link
Member

@encukou, could you please backport this PR to 3.11 and 3.10? It is necessary for backporting #99613, #99651, #99868, and others.

@encukou
Copy link
Member Author

encukou commented Nov 29, 2022

I'd rather not -- _testcapi is only split up in 3.12. It would need backporting at least some of the other PRs in #93649.
I can rebase #99613 instead, would that help?

@serhiy-storchaka
Copy link
Member

Are you volunteering to backport also #99651, #99868 and future tests?

@encukou
Copy link
Member Author

encukou commented Nov 29, 2022

I can put them on my TODO list.
The C changes are mostly about adding new functions, aren't they?

@serhiy-storchaka
Copy link
Member

I think that it would be less work to split _testcapi in 3.11 and 3.10, so I will try this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants