Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-93649: Split heaptype tests from _testcapimodule.c #95386

Merged
merged 2 commits into from
Aug 1, 2022

Conversation

encukou
Copy link
Member

@encukou encukou commented Jul 28, 2022

I'll need to add a test related to heap types, so I'm splitting these out before that to make the test module more manageable.

encukou added 2 commits July 28, 2022 17:06
The type this function would create is available as
    _testcapi.HeapCTypeWithNegativeDict
@encukou encukou requested a review from a team as a code owner July 28, 2022 15:23
@encukou encukou added skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Jul 29, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @encukou for commit 78ae2ba 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 29, 2022
@encukou encukou merged commit 664e96a into python:main Aug 1, 2022
@encukou encukou deleted the split-heaptype-tests branch August 1, 2022 13:04
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x SLES 3.x has failed when building commit 664e96a.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/540/builds/3379) and take a look at the build logs.
  4. Check if the failure is related to this commit (664e96a) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/540/builds/3379

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

421 tests OK.

10 slowest tests:

  • test_concurrent_futures: 2 min 33 sec
  • test_multiprocessing_spawn: 2 min 6 sec
  • test_tools: 2 min 3 sec
  • test_multiprocessing_forkserver: 1 min 16 sec
  • test_asyncio: 1 min 13 sec
  • test_capi: 1 min 8 sec
  • test_signal: 1 min 8 sec
  • test_multiprocessing_fork: 1 min 7 sec
  • test_tokenize: 50.6 sec
  • test_gdb: 46.2 sec

1 test altered the execution environment:
test_import

14 tests skipped:
test_devpoll test_ioctl test_kqueue test_launcher test_msilib
test_nis test_startfile test_tix test_tkinter test_ttk
test_winconsoleio test_winreg test_winsound test_zipfile64

Total duration: 6 min 27 sec

Click to see traceback logs
TracebackTests.test_broken_from) ... ok


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/threading.py", line 1036, in _bootstrap_inner
    self.run()
  File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/threading.py", line 973, in run
    self._target(*self._args, **self._kwargs)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/test/test_import/__init__.py", line 471, in run
    sys.settrace(None)
RuntimeError: Cannot install a trace function while another trace function is being installed
k


TracebackTests.test_unencodable_filename) ... ok


TracebackTests.test_broken_parent) ... ok


TracebackTests.test_nonexistent_module) ... ok


TracebackTests.test_syntax_error) ... ok


TracebackTests.test_broken_parent_from) ... ok


TracebackTests.test_exec_failure) ... ok


TracebackTests.test_import_bug) ... ok


TracebackTests.test_nonexistent_module_nested) ... ok


TracebackTests.test_exec_failure_nested) ... ok


TracebackTests.test_broken_submodule) ... ok

@encukou
Copy link
Member Author

encukou commented Aug 1, 2022

That failure looks unrelated.

@encukou
Copy link
Member Author

encukou commented Aug 1, 2022

The buildbot's next job passed: https://buildbot.python.org/all/#/builders/540/builds/3380

@ezio-melotti
Copy link
Member

@encukou, it seems that this PR introduced two unused vars:

PyTypeObject *class_tp = (PyTypeObject *)class;
PyHeapTypeObject *class_ht = (PyHeapTypeObject *)class;

I'm seeing warnings about it in https://github.com/python/cpython/pull/95874/files:
image

@encukou
Copy link
Member Author

encukou commented Aug 17, 2022

Thanks for the catch! The warnings will be fixed in #95992

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants