gh-94996: Disallow parsing pos only param with feature_version < (3, 8) #94997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hauntsaninja
commented
Jul 19, 2022
•
hauntsaninja
commented
- Issue: ast.parse allows positional-only params with old feature_version #94996
hauntsaninja
added
needs backport to 3.10
|
Thanks @hauntsaninja for the PR, and @lysnikolaou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
Sorry, @hauntsaninja and @lysnikolaou, I could not cleanly backport this to |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 12, 2022
… < (3, 8) (pythonGH-94997) (cherry picked from commit b5e3ea2) Co-authored-by: Shantanu <[email protected]>
|
GH-95931 is a backport of this pull request to the 3.11 branch. |
|
@hauntsaninja Are you backporting this to 3.10 or should I? |
miss-islington
added a commit
that referenced
this pull request
Aug 12, 2022
… 8) (GH-94997) (cherry picked from commit b5e3ea2) Co-authored-by: Shantanu <[email protected]>
|
I can backport it! |
hauntsaninja
added a commit
to hauntsaninja/cpython
that referenced
this pull request
Aug 12, 2022
… < (3, 8) (pythonGH-94997) (cherry picked from commit b5e3ea2)
hauntsaninja
added a commit
to hauntsaninja/cpython
that referenced
this pull request
Aug 12, 2022
…version < (3, 8) (pythonGH-94997). (cherry picked from commit b5e3ea2) Co-authored-by: Shantanu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.