gh-93910: [Enum] restore member.member restriction while keeping performance boost #94913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanfurman
changed the title
ethanfurman
added
3.11
|
Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-94915 is a backport of this pull request to the 3.11 branch. |
ethanfurman
added
stdlib
|
Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 17, 2022
…g performance boost (pythonGH-94913) (cherry picked from commit c20186c) Co-authored-by: Ethan Furman <[email protected]>
hauntsaninja
added a commit
to hauntsaninja/cpython
that referenced
this pull request
Jul 17, 2022
This halves access to attributes such as methods or _sunder_ name
Benchmarked using:
```
from enum import Enum
class Color(Enum):
RED = "Red"
BLUE = "Blue"
GREEN = "Green"
def f():
for _ in range(1000):
Color.RED
Color.BLUE
Color.GREEN
def g():
for _ in range(1000):
Color.RED._name_
Color.BLUE._name_
Color.GREEN._name_
import timeit
print(timeit.timeit('f()', number=10000, globals=globals()))
print(timeit.timeit('g()', number=10000, globals=globals()))
```
As of today morning:
```
6da988a λ ./python.exe bm_enum.py
1.499613167019561
1.5516562079428695
```
As of the latest enum change python#94913:
```
c20186c λ ./python.exe bm_enum.py
1.4998537090141326
16.095267291995697
```
As of this PR:
```
pythongh-93910-micro λ ./python.exe bm_enum.py
1.4983433339511976
8.81327024998609
```
miss-islington
added a commit
that referenced
this pull request
Jul 17, 2022
…ormance boost (GH-94913) (cherry picked from commit c20186c) Co-authored-by: Ethan Furman <[email protected]>
ethanfurman
added a commit
that referenced
this pull request
Jul 18, 2022
ethanfurman
added a commit
that referenced
this pull request
Jul 18, 2022
ethanfurman
added a commit
that referenced
this pull request
Jul 18, 2022
gpshead
pushed a commit
that referenced
this pull request
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores the restriction removed in #94614 while keeping the performance boost.