-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-94801: Use custom flags to check for headers and libs #94802
Conversation
I addressed most places. The code now correctly triggers Emscripten's embuilder to download and install ports. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! LGTM.
1 similar comment
Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Sorry, @tiran, I could not cleanly backport this to |
…pythonGH-94802). (cherry picked from commit 944ff8c) Co-authored-by: Christian Heimes <christian@python.org>
GH-94881 is a backport of this pull request to the 3.11 branch. |
Automerge-Triggered-By: GH:tiran