Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-94759: Create LCOV report with branch coverage (GH-94793) #94793

Merged
merged 1 commit into from
Jul 13, 2022
Merged

gh-94759: Create LCOV report with branch coverage (GH-94793) #94793

merged 1 commit into from
Jul 13, 2022

Conversation

tiran
Copy link
Member

@tiran tiran commented Jul 12, 2022 •
edited by bedevere-bot
Loading

  • fixed issue linker flags, LIBS is not passed to BLDSHARED
  • include version and git commit in output
  • include "Includes" directory, headers now have inline functions

@tiran
pythongh-94759: Create LCOV report with branch coverage
f87ac08 
- fixed issue linker flags, LIBS is not passed to BLDSHARED
- include version and git commit in output
- include "Includes" directory, headers now have inline functions
@tiran tiran added build The build process and cross-build needs backport to 3.11 only security fixes labels Jul 12, 2022
@tiran tiran requested a review from gpshead July 12, 2022 21:56
mdboom
mdboom approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@mdboom mdboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried this and it works for me locally (Debian bookworm WSL)

@tiran tiran changed the title gh-94759: Create LCOV report with branch coverage gh-94759: Create LCOV report with branch coverage (GH-94793) Jul 13, 2022
@tiran tiran merged commit f5c02af into python:main Jul 13, 2022
@tiran tiran deleted the lcov-branch branch July 13, 2022 14:35
@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 13, 2022
@tiran @miss-islington
pythongh-94759: Create LCOV report with branch coverage (pythonGH-94793)
556f685 
(cherry picked from commit f5c02af)

Co-authored-by: Christian Heimes <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 13, 2022
@bedevere-bot
Copy link

GH-94804 is a backport of this pull request to the 3.11 branch.

miss-islington added a commit that referenced this pull request Jul 13, 2022
@miss-islington @tiran
gh-94759: Create LCOV report with branch coverage (GH-94793)
f44a9dc 
(cherry picked from commit f5c02af)

Co-authored-by: Christian Heimes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdboom mdboom mdboom approved these changes

@gpshead gpshead Awaiting requested review from gpshead

Assignees
No one assigned
Labels
build The build process and cross-build skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiran @miss-islington @bedevere-bot @mdboom