Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.11] gh-79579: Improve DML query detection in sqlite3 (GH-93623) #93800

Merged
merged 1 commit into from
Jun 14, 2022
Merged

[3.11] gh-79579: Improve DML query detection in sqlite3 (GH-93623) #93800

merged 1 commit into from
Jun 14, 2022

Commits on Jun 14, 2022

  1. [3.11] pythongh-79579: Improve DML query detection in sqlite3 (python… 

    …GH-93623)

The fix involves using pysqlite_check_remaining_sql(), not only to check
for multiple statements, but now also to strip leading comments and
whitespace from SQL statements, so we can improve DML query detection.

pysqlite_check_remaining_sql() is renamed lstrip_sql(), to more
accurately reflect its function, and hardened to handle more SQL comment
corner cases.
(cherry picked from commit 4674007)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
    @erlend-aasland
    erlend-aasland committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    a521b3c View commit details
    Browse the repository at this point in the history