Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-93678: reduce boilerplate and code repetition in the compiler #93682

Merged
merged 18 commits into from
Jun 14, 2022
Merged

GH-93678: reduce boilerplate and code repetition in the compiler #93682

merged 18 commits into from
Jun 14, 2022

Commits on Jun 10, 2022

  1. move line/noline to arg and remove _noline version of functions

    @iritkatriel
    iritkatriel committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    996be64 View commit details
    Browse the repository at this point in the history

  2. add struct location to reduce boilerplate

    @iritkatriel
    iritkatriel committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    af31e92 View commit details
    Browse the repository at this point in the history

  3. merge basicblock_addop, basicblock_addop_i and basicblock_add_jump in… 

    …to one functions to reduce unnecessary repetition
    @iritkatriel
    iritkatriel committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    f8a0767 View commit details
    Browse the repository at this point in the history

  4. add news

    @iritkatriel
    iritkatriel committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    430b4b9 View commit details
    Browse the repository at this point in the history

  5. assume that oparg is < (1<<30)

    @iritkatriel
    iritkatriel committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    66d5609 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/main' into codegen-reduce-repe… 

    …tition
    @iritkatriel
    iritkatriel committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    7670a7c View commit details
    Browse the repository at this point in the history

  7. use the new location struct for the compiler unit's location

    @iritkatriel
    iritkatriel committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    7d74572 View commit details
    Browse the repository at this point in the history

  8. use the new location struct for the instruction location

    @iritkatriel
    iritkatriel committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    016ebbc View commit details
    Browse the repository at this point in the history

  9. basicblock_addop takes location by reference

    @iritkatriel
    iritkatriel committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    5e06cad View commit details
    Browse the repository at this point in the history

  10. LOCATION needs to return a const

    @iritkatriel
    iritkatriel committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    c23e2cf View commit details
    Browse the repository at this point in the history

  11. define static no_location in function scope

    @iritkatriel
    iritkatriel committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    fc74555 View commit details
    Browse the repository at this point in the history

  12. are we const now?

    @iritkatriel
    iritkatriel committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    9220fc1 View commit details
    Browse the repository at this point in the history

  13. trivial stuff

    @iritkatriel
    iritkatriel committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    9b5dc34 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2022

  1. Merge remote-tracking branch 'upstream/main' into codegen-reduce-repe… 

    …tition
    @iritkatriel
    iritkatriel committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    5330060 View commit details
    Browse the repository at this point in the history

  2. remove two unused fields from struct assembler

    @iritkatriel
    iritkatriel committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    414e26a View commit details
    Browse the repository at this point in the history

  3. define NO_LOCATION as a static const in global scope

    @iritkatriel
    iritkatriel committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    26dc190 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2022

  1. Merge remote-tracking branch 'upstream/main' into codegen-reduce-repe… 

    …tition
    @iritkatriel
    iritkatriel committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    98d24f2 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into codegen-reduce-repe… 

    …tition
    @iritkatriel
    iritkatriel committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    7851ccd View commit details
    Browse the repository at this point in the history