Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-85299: Add note warning about entry point guard for asyncio example #93457

Merged
merged 5 commits into from
Oct 16, 2022
Merged

gh-85299: Add note warning about entry point guard for asyncio example #93457

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
97d022e
Add note warning about entry point guard for asyncio example
slateny Jun 3, 2022
16cb255
Add entry guard, clarify note on platform
slateny Oct 15, 2022
0129bdf
Add ref target in multiprocessing
slateny Oct 16, 2022
fd68a5e
Use rewording for multiprocessing
slateny Oct 16, 2022
8ba4b0c
Add missing grave sign
slateny Oct 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Doc/library/asyncio-eventloop.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1208,6 +1208,12 @@ Executing code in thread or process pools

asyncio.run(main())

Note that on macOS, an entry point guard may be needed as the example would
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to just add __name__ == '__main__'. This happens on Windows too not just macOS.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point, Windows also defaults to spawn so looks like it runs into the same issue as mac. Should this note still remain as an fyi, or just change the example to fix the problem and leave out the note? It's customary to have the guard in general but knowing why it fails without might still be helpful, but I don't feel too strongly either way.

otherwise cause a :exc:`RuntimeError`. See the `Changed in version 3.8 note
<https://docs.python.org/3/library/multiprocessing.html#contexts-and-start-methods>`_
and `Safe importing of main module
<https://docs.python.org/3/library/multiprocessing.html#the-spawn-and-forkserver-start-methods>`_.

This method returns a :class:`asyncio.Future` object.

Use :func:`functools.partial` :ref:`to pass keyword arguments
Expand Down