gh-92597: Improve error message for AST nodes with invalid ranges #93398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isidentical
approved these changes
Jun 1, 2022
Python/ast.c
Outdated
| node->lineno, node->end_lineno); \ | ||
| return 0; \ | ||
| } \ | ||
| if ((node->lineno < 0 && node->end_lineno != node->lineno) || \ | ||
| (node->col_offset < 0 && node->col_offset != node->end_col_offset)) { \ | ||
| PyErr_Format(PyExc_ValueError, \ | ||
| "line %d-%d, column %d-%d is not a valid range", \ | ||
| node->lineno, node->end_lineno, node->col_offset, node->end_col_offset); \ | ||
| "AST node column range (%d, %d) for line %d is not valid", \ |
There was a problem hiding this comment.
Do we want to include the end_lineno here as well (since it is part of the original condition):
if ((node->lineno < 0 && node->end_lineno != node->lineno) || \
pablogsal
commented
Jun 1, 2022
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-93414 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 1, 2022
…es (pythonGH-93398) (cherry picked from commit 8a221a8) Co-authored-by: Pablo Galindo Salgado <[email protected]>
pablogsal
added a commit
that referenced
this pull request
Jun 1, 2022
…-93398) (GH-93414) (cherry picked from commit 8a221a8) Co-authored-by: Pablo Galindo Salgado <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.