Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-93243: Make smtpd private before porting its users #93246

Merged
merged 19 commits into from
Aug 6, 2022
Merged

gh-93243: Make smtpd private before porting its users #93246

merged 19 commits into from
Aug 6, 2022

Conversation

arhadthedev
Copy link
Member

@arhadthedev arhadthedev commented May 26, 2022 •
edited by miss-islington
Loading

gh-93243

This PR is required to reduce diffs of the following porting (no need to either maintain documentation and tests consistent with each porting step, or try to port everything and remove smtpd in a single PR).

Automerge-Triggered-By: GH:warsaw

@arhadthedev arhadthedev requested review from a team and vsajip as code owners May 26, 2022 06:49
AA-Turner
AA-Turner reviewed Jun 4, 2022
View reviewed changes
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some docs/wording comments:

A

Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
Lib/test/mock_socket.py Outdated Show resolved Hide resolved
Lib/test/mock_socket.py Outdated Show resolved Hide resolved
Misc/NEWS.d/next/Library/2022-05-26-08-41-34.gh-issue-93243.uw6x5z.rst Outdated Show resolved Hide resolved
AA-Turner
AA-Turner reviewed Jun 4, 2022
View reviewed changes
Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
@hugovk
Copy link
Member

hugovk commented Jun 4, 2022

cc also PEP-594 co-author @brettcannon.

brettcannon
brettcannon requested changes Jun 8, 2022
View reviewed changes
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably need logging and email maintainers to sign off that they are okay with keeping smptd around for testing.

Lib/test/test_logging.py Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@arhadthedev
Copy link
Member Author

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from brettcannon June 8, 2022 21:17
@arhadthedev
Copy link
Member Author

arhadthedev commented Jul 29, 2022 •
edited
Loading

Probably need logging and email maintainers to sign off that they are okay with keeping smptd around for testing.

@vsajip @warsaw could you review and possibly merge this PR please? It deletes smtpd tests in advance and, for consistency, makes the module private by moving it into Lib/test/smtpd.py.

This is necessary to allow further reviewable-sized PRs (one for each SMTP* class moved into its consumer in test) without massive changes of Lib/test/test_smtpd.py for synchronization.

warsaw
warsaw requested changes Aug 4, 2022
View reviewed changes
Copy link
Member

@warsaw warsaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a small rewording request.

Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@arhadthedev
Copy link
Member Author

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@brettcannon, @warsaw: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from warsaw August 4, 2022 19:25
@warsaw
Update 3.12.rst
e351af3 
Wording suggestion.
@brettcannon
Copy link
Member

@warsaw not sure if this is showing up in your review queue as the GH UI is not letting me re-request your review.

@warsaw
Update 3.12.rst
1d157ec 
Small reword suggestion.
@warsaw
Copy link
Member

warsaw commented Aug 6, 2022

Thanks for the ping @brettcannon - I'm good with this, with my one edit to the source branch. I thought I'd pushed that through previously, but upon further review, it doesn't look like it stuck. Trying that again...

warsaw
warsaw approved these changes Aug 6, 2022
View reviewed changes
Copy link
Member

@warsaw warsaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this time it looks like my small wording edit got committed. Thanks for the contribution @arhadthedev ! Approving and setting the automerge label.

@miss-islington
Copy link
Contributor

Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 56d16e8 into python:main Aug 6, 2022
@arhadthedev arhadthedev deleted the privatize-smtpd branch August 7, 2022 06:55
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Aug 11, 2022
@arhadthedev @iritkatriel
pythongh-93243: Make smtpd private before porting its users (pythonGH…
10dc75f 
…-93246)

pythongh-93243

This PR is required to reduce diffs of the following porting (no need to either maintain documentation and tests consistent with each porting step, or try to port everything and remove smtpd in a single PR).

Automerge-Triggered-By: GH:warsaw
@sobolevn sobolevn mentioned this pull request Sep 5, 2022
Merged
@arhadthedev arhadthedev mentioned this pull request Oct 6, 2022
Open
12 tasks
@hugovk hugovk mentioned this pull request Oct 28, 2022
Closed
@vstinner vstinner mentioned this pull request Nov 8, 2022
Closed
@sobolevn sobolevn mentioned this pull request Jan 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AA-Turner AA-Turner AA-Turner left review comments

@hugovk hugovk hugovk left review comments

@warsaw warsaw warsaw approved these changes

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@arhadthedev @hugovk @bedevere-bot @brettcannon @warsaw @miss-islington @AA-Turner