gh-92898: Enhance _testcppext test on cast to PyObject* #93111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vstinner
commented
May 23, 2022
vstinner
commented
- Add StrongRef class.
- Rename and reformat functions of the _Py_CAST() implementation.
* Add StrongRef class. * Rename and reformat functions of the _Py_CAST() implementation.
|
I'm not sure that having a separated _Py_STATIC_CAST() macro is still needed with the new _Py_CAST() implementation. Maybe _Py_STATIC_CAST() can now be replaced with _Py_CAST(). |
|
I added a NEWS entry for #92951 change, since at least greenlet and scipy were impacted by C++ compiler warnings with Python 3.11 beta1. |
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 26, 2022
…GH-93111) * Add StrongRef class. * Rename and reformat functions of the _Py_CAST() implementation. (cherry picked from commit 20d30ba) Co-authored-by: Victor Stinner <[email protected]>
|
GH-93275 is a backport of this pull request to the 3.11 branch. |
miss-islington
added a commit
that referenced
this pull request
May 26, 2022
* Add StrongRef class. * Rename and reformat functions of the _Py_CAST() implementation. (cherry picked from commit 20d30ba) Co-authored-by: Victor Stinner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.