-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change __future__
docs description to avoid confusion with concurrency futures
#92760
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like an improvement to me.
Co-authored-by: Carl Meyer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I don't find the current wording unclear, and the proposed new wording is so long that it will make the page title spill into multiple lines on many screens. If another core dev has a different opinion, I won't object to merging this though. |
@JelleZijlstra Will Edit: for comparison:
|
Applied the shorter wording described above. |
__future__
docs description from concurrency futures__future__
docs description to avoid confusion with concurrency futures
Ping. |
Sorry, I still don't see a reason for change here. I'm leaving this open in case another core dev thinks there's room for improvement, but I'm not planning to merge anything. |
Currently, the library index page describes
__future__
as:However, it creates confusion with futures from the concurrency domain. So this PR changes the description to:
Edit: replaced with a shorter wording: