Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-91960: Add FreeBSD build and test using Cirrus-CI #91961

Merged
merged 3 commits into from
Sep 6, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .cirrus.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
freebsd_task:
freebsd_instance:
matrix:
- image: freebsd-13-2-release-amd64
# Turn off TCP and UDP blackhole. It is not enabled by default in FreeBSD,
# but it is in the FreeBSD GCE images as used by Cirrus-CI. It causes even
# local local connections to fail with ETIMEDOUT instead of ECONNREFUSED.
# For more information see https://reviews.freebsd.org/D41751 and
# https://github.com/cirruslabs/cirrus-ci-docs/issues/483.
sysctl_script:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind to add a comment to explain these commands? Maybe add add these two links:

# https://github.com/cirruslabs/cirrus-ci-docs/issues/483
# https://reviews.freebsd.org/D41751

- sysctl net.inet.tcp.blackhole=0
- sysctl net.inet.udp.blackhole=0
build_script:
- mkdir build
- cd build
- ../configure --with-pydebug
- make -j$(sysctl -n hw.ncpu)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add:

- make pythoninfo

It's a tool to dump various kind of informations about the platform to ease debug.

Look at the end of: https://api.cirrus-ci.com/v1/task/6753062602145792/logs/build.log

I don't know if it's possible to add a 3rd "pythoninfo_script:" section? Well, it's not needed, I'm fine with adding it at the end of build_script.

pythoninfo_script:
- cd build && make pythoninfo
test_script:
- cd build
# dtrace fails to build on FreeBSD - see gh-73263
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for referencing the rationale for a skip!

- make buildbottest TESTOPTS="-j0 -x test_dtrace"
vstinner marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
FreeBSD 13.2 CI coverage for pull requests is now provided by Cirrus-CI (a hosted CI service that supports Linux, macOS, Windows, and FreeBSD).
Loading