Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-46836: Move PyFrameObject to pycore_frame.h #31530

Merged
merged 1 commit into from
Feb 25, 2022
Merged

bpo-46836: Move PyFrameObject to pycore_frame.h #31530

merged 1 commit into from
Feb 25, 2022

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Feb 23, 2022

Move the PyFrameObject type definition (struct _frame) to the
internal C API: to the pycore_frame.h header file.

https://bugs.python.org/issue46836

@vstinner
Copy link
Member Author

I marked this PR as a draft since this change is an incompatible change: see https://bugs.python.org/issue46836#msg413805

@vstinner vstinner marked this pull request as ready for review February 24, 2022 15:44
Move the PyFrameObject type definition (struct _frame) to the
internal C API pycore_frame.h header file.
@vstinner vstinner merged commit 18b5dd6 into python:main Feb 25, 2022
@vstinner vstinner deleted the internal_frame branch February 25, 2022 11:53
asvetlov pushed a commit that referenced this pull request Feb 26, 2022
Move the PyFrameObject type definition (struct _frame) to the
internal C API pycore_frame.h header file.
tacaswell added a commit to tacaswell/pybind11 that referenced this pull request Feb 27, 2022
In 18b5dd68c6b616257ae243c0b6bb965ffc885a23 /
python/cpython#31530 /
https://bugs.python.org/issue46836

the _frame struct was moved to an internal header, however the public API is
primarily read-only.
tacaswell added a commit to tacaswell/cython that referenced this pull request Feb 27, 2022
In 18b5dd68c6b616257ae243c0b6bb965ffc885a23 /
python/cpython#31530 /
https://bugs.python.org/issue46836

The `_frame` struct was moved to an internal header, however the public API is
primarily read-only, and cython needs to build _frame objects so still import
the internal headers.
tacaswell added a commit to tacaswell/cython that referenced this pull request Mar 4, 2022
In 18b5dd68c6b616257ae243c0b6bb965ffc885a23 /
python/cpython#31530 /
https://bugs.python.org/issue46836

The `_frame` struct was moved to an internal header, however the public API is
primarily read-only, and cython needs to build _frame objects so still import
the internal headers.
scoder pushed a commit to cython/cython that referenced this pull request Mar 12, 2022
In python/cpython#31530
https://bugs.python.org/issue46836

the `_frame` struct was moved to an internal header, however the public API is
primarily read-only, and Cython needs to build PyFrameObjects so still import
the internal headers.

Also sets the Py_BUILD_CORE define for py311a6, trying to restrict it to the frame header.
scoder pushed a commit to cython/cython that referenced this pull request Mar 12, 2022
In python/cpython#31530
https://bugs.python.org/issue46836

the `_frame` struct was moved to an internal header, however the public API is
primarily read-only, and Cython needs to build PyFrameObjects so still import
the internal headers.

Also sets the Py_BUILD_CORE define for py311a6, trying to restrict it to the frame header.
JukkaL pushed a commit to python/mypy that referenced this pull request May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants