Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-46805: Add low level UDP socket functions to asyncio #31455

Merged
merged 14 commits into from
Mar 13, 2022

Conversation

agronholm
Copy link
Contributor

@agronholm agronholm commented Feb 20, 2022

  • sock_sendto()
  • sock_recvfrom()
  • sock_recvfrom_into()

https://bugs.python.org/issue46805

* sock_sendto()
* sock_recvfrom()
* sock_recvfrom_into()
@agronholm agronholm marked this pull request as ready for review February 27, 2022 23:19
Modules/overlapped.c Outdated Show resolved Hide resolved
Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new methods should be mentioned in 3.11 whatsnew

@agronholm
Copy link
Contributor Author

The new methods should be mentioned in 3.11 whatsnew

They're already mentioned in the news blurb in this PR.

@kumaraditya303
Copy link
Contributor

It should also be mentioned in the Improved Modules section of whatsnew under asyncio.

@agronholm
Copy link
Contributor Author

It should also be mentioned in the Improved Modules section of whatsnew under asyncio.

What do I need to do?

@kumaraditya303
Copy link
Contributor

It should also be mentioned in the Improved Modules section of whatsnew under asyncio.

What do I need to do?

Add new methods here https://github.com/python/cpython/blob/main/Doc/whatsnew/3.11.rst, See https://github.com/python/cpython/blob/main/Doc/whatsnew/3.11.rst#inspect for inspect module as an example.

@agronholm
Copy link
Contributor Author

It should also be mentioned in the Improved Modules section of whatsnew under asyncio.

Done.

Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix minor notes

Doc/library/asyncio-eventloop.rst Outdated Show resolved Hide resolved
Modules/overlapped.c Outdated Show resolved Hide resolved
Modules/overlapped.c Outdated Show resolved Hide resolved
Modules/overlapped.c Outdated Show resolved Hide resolved
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@asvetlov asvetlov merged commit 9f04ee5 into python:main Mar 13, 2022
@agronholm agronholm deleted the fix-issue-46805 branch March 13, 2022 16:43
@agronholm
Copy link
Contributor Author

Thanks for reviewing!

carljm pushed a commit to carljm/cpython that referenced this pull request Mar 14, 2022
* main: (94 commits)
  Revert "bpo-46986: Upgrade bundled setuptools to 60.9.3 (pythonGH-31820)" (pythonGH-31879)
  bpo-30677: [doc] mention that os.mkdir() can raise FileNotFoundError (pythonGH-31548)
  git ignore Lib/site-packages (pythonGH-31862)
  bpo-31415: importtime was made by Inada Naoki (pythonGH-31875)
  bpo-46920: Remove code that has explainers why it was disabled (pythonGH-31813)
  bpo-46920: Remove disabled debug code added decades ago and likely unnecessary (pythonGH-31812)
  bpo-46920: Remove code that has no explainer why it was disabled (pythonGH-31814)
  bpo-46906: Mention native endian in PyFloat_Pack8() doc (pythonGH-31866)
  bpo-40280: select: Use NULL for empty fdset (pythonGH-31865)
  CI: Fix patchcheck (pythonGH-31708)
  bpo-46987: Remove _PySys_GetObjectId / _PySys_GetObjectId (pythonGH-31835)
  bpo-46994: Accept explicit contextvars.Context in asyncio create_task() API (pythonGH-31837)
  bpo-39829: Fix `__len__()` is called twice in list() constructor (pythonGH-31816)
  bpo-47003: Cleanup _overlapped module (pythonGH-31848)
  bpo-47004: Sync with importlib_metadata 4.11.3. (python#31854)
  bpo-46986: Upgrade bundled setuptools to 60.9.3 (pythonGH-31820)
  bpo-46985: Upgrade bundled pip to 22.0.4 (pythonGH-31819)
  bpo-46805: Add low level UDP socket functions to asyncio (pythonGH-31455)
  bpo-46995: Deprecate missing asyncio.Task.set_name() for third-party task implementations (pythonGH-31838)
  bpo-43215: Document Happy Eyeballs args of asyncio.open_connection (pythonGH-24525)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants