Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-46648: test_urllib2.test_issue16464() uses httpbin.org #31146

Closed
wants to merge 1 commit into from
Closed

bpo-46648: test_urllib2.test_issue16464() uses httpbin.org #31146

wants to merge 1 commit into from

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Feb 5, 2022

The test_issue16464() test of test_urllib2 now uses
"http://httpbin.org/post" URL instead of "http://www.example.com/".

https://bugs.python.org/issue46648

The test_issue16464() test of test_urllib2 now uses
"http://httpbin.org/post" URL instead of "http://www.example.com/".
@vstinner
Copy link
Member Author

vstinner commented Feb 5, 2022

cc @corona10 @ambv

Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a different, more reliable service. The git repo and container image of the service hasn't been maintained in years.

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@vstinner
Copy link
Member Author

vstinner commented Feb 5, 2022

Please use a different, more reliable service. The git repo and container image of the service hasn't been maintained in years.

test_urllib2 is failing on all buildbots right now because example.com is no longer reliable. Do you have a better suggestion?

I'm not aware of any pythontest.net URL supporting POST.

Either we switch to any other URL or the test should be skipped. Most buildbots are failing.

@orsenthil
Copy link
Member

Hi @vstinner, I am with @tiran here. If possible m we should use pythontest . I think, it supports simple post.

If blocked by external resources, we can skip the test. BTW test_urllib2net is supposed to depend on external sources. The test_urllib2 should have mocks.

@vstinner vstinner closed this Feb 6, 2022
@vstinner vstinner deleted the urllib2_issue16464 branch February 6, 2022 14:09
@vstinner
Copy link
Member Author

vstinner commented Feb 6, 2022

I merged my PR #31161 instead (skip the test).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting changes tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants