Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40280: Use presence of msvcrt module to detect Windows #30930

Merged
merged 2 commits into from
Jan 27, 2022
Merged

bpo-40280: Use presence of msvcrt module to detect Windows #30930

merged 2 commits into from
Jan 27, 2022
+9 −4

Conversation

tiran
Copy link
Member

@tiran tiran commented Jan 26, 2022 •
edited by miss-islington
Loading

https://bugs.python.org/issue40280

Automerge-Triggered-By: GH:tiran

@tiran tiran requested a review from zware January 26, 2022 22:23
@tiran tiran requested a review from gpshead as a code owner January 26, 2022 22:23
@tiran tiran mentioned this pull request Jan 26, 2022
Merged
zware
zware approved these changes Jan 26, 2022
View reviewed changes
Copy link
Member

@zware zware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zware
Copy link
Member

zware commented Jan 26, 2022

The NEWS entry from GH-30620 will need some rewording.

@miss-islington miss-islington merged commit 606e496 into python:main Jan 27, 2022
@SimonBiggs SimonBiggs mannequin mentioned this pull request Jun 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zware zware zware approved these changes

@gpshead gpshead gpshead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tiran @zware @gpshead @the-knights-who-say-ni @bedevere-bot @miss-islington