Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46315: Add ifdef HAVE_ feature checks for WASI compatibility (GH-30507) #30507

Merged
merged 1 commit into from
Jan 13, 2022
Merged

bpo-46315: Add ifdef HAVE_ feature checks for WASI compatibility (GH-30507) #30507

merged 1 commit into from
Jan 13, 2022

Conversation

tiran
Copy link
Member

@tiran tiran commented Jan 9, 2022 •
edited by bedevere-bot
Loading

  • add check for HAVE_CLOCK
  • use HAVE_PTHREAD_H to guard include of pthread.h
  • guard getpid() with HAVE_GETPID
  • guard clock() with HAVE_CLOCK
  • add checks for HAVE_UMASK and HAVE_CHMOD
  • guard include of setjmp.h
  • use signal emulation on WASI

https://bugs.python.org/issue46315

@tiran tiran requested review from rhettinger and a team as code owners January 9, 2022 18:46
erlend-aasland
erlend-aasland approved these changes Jan 9, 2022
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tiran
bpo-46315: Add ifdef HAVE_ feature checks for WASI compatibility
859bbbc 
* add check for HAVE_CLOCK
* use HAVE_PTHREAD_H to guard include of pthread.h
* guard getpid() with HAVE_GETPID
* guard clock() with HAVE_CLOCK
* add checks for HAVE_UMASK and HAVE_CHMOD
* guard include of setjmp.h
* use signal emulation on WASI
@tiran tiran changed the title bpo-46315: Add ifdef HAVE_ feature checks for WASI compatibility bpo-46315: Add ifdef HAVE_ feature checks for WASI compatibility (GH-30507) Jan 13, 2022
@tiran tiran merged commit a6ca8ee into python:main Jan 13, 2022
@tiran tiran deleted the bpo-46315-wasi branch January 13, 2022 08:46
@tiran tiran mentioned this pull request Oct 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiran @erlend-aasland @the-knights-who-say-ni @bedevere-bot