gh-89398: Fix argparse namespace overridden by subparsers default #30219
+49
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def _get_kwargs(self): | ||
| kwargs = self.__defaults__ | self.__dict__ | ||
| kwargs.pop('__defaults__', None) | ||
| return list(kwargs.items()) |
There was a problem hiding this comment.
Why do you convert it into a list if the caller (__eq__) turns it into a dict again?
There was a problem hiding this comment.
The __repr__ implementation of the parent class _AttributeHolder also calls this. But this change can be considered.
There was a problem hiding this comment.
Ah right, I should have checked that. Better to just leave it as is then.
MaxwellDupre
approved these changes
Feb 18, 2022
|
All commit authors signed the Contributor License Agreement. |
frostming
force-pushed
the
fix/45235-argparse-overrided-by-defaults-2
branch
from
2281bfe to
4c5cc3c
Compare
frostming
changed the title
frostming
force-pushed
the
fix/45235-argparse-overrided-by-defaults-2
branch
from
4c5cc3c to
95cb850
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix gh-89398 with another approach than #29574.
The default values are stored in a dunder attribute in
Namespaceto ensure they don't override the given values.