Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-45582: Fix getpath_isxfile() and test_embed on Windows #29930

Merged
merged 2 commits into from
Dec 6, 2021
Merged

bpo-45582: Fix getpath_isxfile() and test_embed on Windows #29930

merged 2 commits into from
Dec 6, 2021

Conversation

neonene
Copy link
Contributor

@neonene neonene commented Dec 6, 2021

Current getpath_isxfile() in getpath.c always returns false.
After the function is fixed, test_embed.py needs a workaround to pass the following tests that have the same error in the release build.

  • test_init_pybuilddir_win32
  • test_init_pyvenv_cfg
FAIL: test_init_pybuilddir_win32 (test.test_embed.InitConfigTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\cp\Lib\test\test_embed.py", line 1322, in test_init_pybuilddir_win32
    self.check_all_configs("test_init_compat_config", config,
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\cp\Lib\test\test_embed.py", line 728, in check_all_configs
    self.check_config(configs, expected_config)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\cp\Lib\test\test_embed.py", line 654, in check_config
    self.assertEqual(config, expected)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: {'_co[316 chars]embed.exe', ...
    ...
-  'program_name': './_testembed.exe',
?                               ----
+  'program_name': './_testembed',
    ...

The debug build passes them using the default program_name, and the PGO build does not due to another issue.

https://bugs.python.org/issue45582

@neonene
Copy link
Contributor Author

neonene commented Dec 7, 2021

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants