Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45893: Add missing extern C to initconfig.h (GH-29761) #29761

Merged
merged 2 commits into from
Nov 24, 2021
Merged

bpo-45893: Add missing extern C to initconfig.h (GH-29761) #29761

merged 2 commits into from
Nov 24, 2021

Conversation

tiran
Copy link
Member

@tiran tiran commented Nov 24, 2021 •
edited by bedevere-bot
Loading

@tiran tiran added the needs backport to 3.10 only security fixes label Nov 24, 2021
gvanrossum
gvanrossum approved these changes Nov 24, 2021
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about Steve's other suggestion?

@tiran
Copy link
Member Author

tiran commented Nov 24, 2021

What about Steve's other suggestion?

Thanks for the ping. I missed his suggestion. I'll amend the PR.

@tiran
Copy link
Member Author

tiran commented Nov 24, 2021

GHA now has:

  python_uwp.cpp
  Generating code
  Finished generating code
  pythonw_uwp.vcxproj -> D:\a\cpython\cpython\PCbuild\amd64\pythonw_uwp.exe

@tiran tiran changed the title bpo-45893: Add missing extern C to initconfig.h bpo-45893: Add missing extern C to initconfig.h (GH-29761) Nov 24, 2021
@tiran tiran merged commit f4afc53 into python:main Nov 24, 2021
@tiran tiran deleted the bpo-45893 branch November 24, 2021 20:12
@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 24, 2021
@tiran @miss-islington
bpo-45893: Add missing extern C to initconfig.h (pythonGH-29761)
bef04ce 
Co-authored-by: Steve Dower <[email protected]>
(cherry picked from commit f4afc53)

Co-authored-by: Christian Heimes <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 24, 2021
@bedevere-bot
Copy link

GH-29765 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit that referenced this pull request Nov 24, 2021
@miss-islington @tiran
bpo-45893: Add missing extern C to initconfig.h (GH-29761)
cd85d91 
Co-authored-by: Steve Dower <[email protected]>
(cherry picked from commit f4afc53)

Co-authored-by: Christian Heimes <[email protected]>
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@tiran @zooba @remykarem
bpo-45893: Add missing extern C to initconfig.h (pythonGH-29761)
6e7a00d 
Co-authored-by: Steve Dower <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tiran @miss-islington @bedevere-bot @gvanrossum @the-knights-who-say-ni