Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45019: Fix freeze_modules.py to print argv incase of error #29744

Merged
merged 1 commit into from
Nov 24, 2021
Merged

bpo-45019: Fix freeze_modules.py to print argv incase of error #29744

merged 1 commit into from
Nov 24, 2021

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Nov 24, 2021 •
edited by bedevere-bot
Loading

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@kumaraditya303

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@kumaraditya303
Copy link
Contributor Author

I signed CLA

@kumaraditya303
Copy link
Contributor Author

cc @ericsnowcurrently

@kumaraditya303 kumaraditya303 changed the title Fix freeze_modules.py to print error incase of error Fix freeze_modules.py to print argv incase of error Nov 24, 2021
gvanrossum
gvanrossum approved these changes Nov 24, 2021
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@gvanrossum gvanrossum changed the title Fix freeze_modules.py to print argv incase of error bpo-45019: Fix freeze_modules.py to print argv incase of error Nov 24, 2021
@gvanrossum
Copy link
Member

The failing tests look like flakes.

@gvanrossum gvanrossum merged commit 256f9c4 into python:main Nov 24, 2021
@bedevere-bot
Copy link

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@kumaraditya303 @remykarem
Fix typo in freeze_modules (python#29744)
dcaa3ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kumaraditya303 @the-knights-who-say-ni @gvanrossum @bedevere-bot