-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-45873: Restore Python 3.6 compatibility (GH-29730) #29730
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but is it even worth testing for 3.7+? Why not always take the slow path?
I left the old implementation in because it's more readable. The fast path is now in a doc string for future reference. I also added more debug code to configure to figure out what is going on on the Debian buildbot. |
Closing and reopening to retrigger Azure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Why do we even bother with "python3 python"? For weird platforms that have only one of those but it happens to be 3.6 or better?)
I don't know and kept |
Co-authored-by: Guido van Rossum <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:-)
@tiran: Status check is done, and it's a failure ❌ . |
Co-authored-by: Guido van Rossum <[email protected]>
https://bugs.python.org/issue45873
Automerge-Triggered-By: GH:tiran