Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-35673: Add a public alias for namespace package __loader__ attribute #29049

Merged
merged 3 commits into from
Oct 20, 2021
Merged

bpo-35673: Add a public alias for namespace package __loader__ attribute #29049

merged 3 commits into from
Oct 20, 2021

Conversation

warsaw
Copy link
Member

@warsaw warsaw commented Oct 19, 2021 •
edited by bedevere-bot
Loading

@warsaw warsaw changed the title Add a public alias for namespace package __loader__ attribute bpo-35673: Add a public alias for namespace package __loader__ attribute Oct 19, 2021
@brettcannon
Copy link
Member

brettcannon commented Oct 19, 2021 •
edited
Loading

One thing to note is I am trying to get rid of __loader__ in favour of __spec__.loader, so maybe make that the motivation?

@warsaw
Copy link
Member Author

warsaw commented Oct 19, 2021

One question for @brettcannon - I wonder if we should rename the class itself to NamespaceLoader and keep _NamespaceLoader as an alias for backward compatibility. It would look better in the repr. I guess I'll try that and see what breaks :D

@warsaw
Swap NamespaceLoader and _NamespaceLoader
cc0a9a4 
The class is named NamespaceLoader and the alias is _NamespaceLoader
@warsaw
Copy link
Member Author

warsaw commented Oct 19, 2021

@brettcannon Like cc0a9a4

@brettcannon
Copy link
Member

I mean it's been a private name up to this point, so people shouldn't be shocked if it's renamed. Plus people shouldn't be pickling the thing, so I don't see any issue with a rename.

ericsnowcurrently
ericsnowcurrently approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I don't know that exposing it adds much value (namespace packages are a special flower anyway) but I don't see any harm.

@warsaw warsaw merged commit 876fc7f into python:main Oct 20, 2021
@bedevere-bot
Copy link

@warsaw: Please replace # with GH- in the commit message next time. Thanks!

@warsaw warsaw deleted the issue35673 branch October 20, 2021 21:05
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Oct 21, 2021
@shihai1991
Merge branch 'main' into bpo_45113_3
9d162ef 
* main: (263 commits)
  bpo-45521: Fix a bug in the obmalloc radix tree code. (pythonGH-29051)
  bpo-45522: Allow to disable freelists on build time (pythonGH-29056)
  bpo-34451: Document prompt and output toggle feature in html tutorial (pythonGH-27105)
  bpo-44019: Add operator.call() to __all__ for the operator module (pythonGH-29110)
  bpo-45315: PyType_FromSpec: Copy spec->name and have the type own the memory for its name (pythonGH-29103)
  bpo-44220: Export PyStructSequence_UnnamedField in the limited API (pythonGH-26331)
  bpo-44174: [Enum] add reference to name mangling (pythonGH-29116)
  bpo-45548: add some missing entries to `Modules/Setup` (pythonGH-29115)
  bpo-35673: Add a public alias for namespace package __loader__ attribute (python#29049)
  bpo-45192: Fix a bug that infers the type of an os.PathLike[bytes] object as str (pythonGH-28323)
  bpo-45527: Don't count cache hits, just misses. (pythonGH-29092)
  bpo-45320: Remove long-deprecated inspect methods (pythonGH-28618)
  bpo-41374: Remove obsolete exclusion of netinet/tcp.h on Cygwin (pythonGH-21649)
  bpo-45532: Replace 'default' with 'main' as default in sys.version (pythonGH-29100)
  bpo-45464: [doc] Explain that subclassing multiple exceptions is fragile (pythonGH-29094)
  Cleanup a couple of comments left on PR 28775 post-merge. (pythonGH-29079)
  bpo-45536: Check OpenSSL APIs in configure (pythonGH-29088)
  Add PEPs 593 & 647 to list of PEPs at top of typing docs (pythonGH-29097)
  Add a comment about how to fix bogus test_host_resolution_bad_address failures (python#29085)
  bpo-44525: Specialize simple Python calls. (pythonGH-29033)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@warsaw @brettcannon @bedevere-bot @ericsnowcurrently @the-knights-who-say-ni