-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-45020: Freeze os, site, and codecs. #28398
bpo-45020: Freeze os, site, and codecs. #28398
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you leave the encodings package for another time? I find the noise caused by the generation of the 120+ files there very distracting: even though they are not in the repo, the Make output still adds 360+ lines each time a dependency of _freeze_module changes, which is pretty much any C or .h file in the project.
It would be nice if we could freeze submodules of a package (and maybe even its __init__.py
file) without freezing the entire package. Perhaps we can think of ways to tweak import.c so that importing "foo.bar" first looks for a frozen foo.bar
before looking in foo.__path_rozen_
?
PS. The default is still "off" right? I only get frozen modules with -X frozen_modules
.
Fine with me. I'm going to run the buildbots on the PR first though.
This seems like something we could fix.
I have a different branch that does the right thing for
Right. |
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 74e292182cfcc8b3413745ddbc543d7a2413b418 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
FYI, I'm working on fixing the "altered the execution environment" (test_socket) failures I'm seeing on the refleak buildbots. [UPDATE] Ah, looks like it wasn't me: https://bugs.python.org/issue45187#msg402074 |
d7f2b64
to
80777a9
Compare
After this, the only modules left that are imported during startup are "encodings.*". We'll tackle that after we make the build output (stdout) less noisy.
https://bugs.python.org/issue45020