Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-45020: Don't test IDLE with frozen module. #28344

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

terryjreedy
Copy link
Member

@terryjreedy terryjreedy commented Sep 15, 2021

Otherwise, test would need special import.

https://bugs.python.org/issue45020

Otherwise, test would need special import.
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@terryjreedy
Copy link
Member Author

terryjreedy commented Sep 15, 2021

https://github.com/python/cpython/pull/28344/checks?check_run_id=3605759743
All tests pass until test_multiprocessing_fork timed out after 25 min. On the rerun:

test_get (test.test_multiprocessing_fork.WithProcessesTestQueue) ... Timeout (0:20:00)!
Thread 0x00007f176a71ebc0 (most recent call first):
File "/home/runner/work/cpython/cpython/Lib/multiprocessing/synchronize.py", line 261 in wait
File "/home/runner/work/cpython/cpython/Lib/multiprocessing/synchronize.py", line 349 in wait
File "/home/runner/work/cpython/cpython/Lib/test/_test_multiprocessing.py", line 1001 in test_get
File "/home/runner/work/cpython/cpython/Lib/unittest/case.py", line 549 in _callTestMethod
File "/home/runner/work/cpython/cpython/Lib/unittest/case.py", line 593 in run
File "/home/runner/work/cpython/cpython/Lib/unittest/case.py", line 652 in call
File "/home/runner/work/cpython/cpython/Lib/unittest/suite.py", line 122 in run
File "/home/runner/work/cpython/cpython/Lib/unittest/suite.py", line 84 in call
File "/home/runner/work/cpython/cpython/Lib/unittest/suite.py", line 122 in run
File "/home/runner/work/cpython/cpython/Lib/unittest/suite.py", line 84 in call
File "/home/runner/work/cpython/cpython/Lib/unittest/suite.py", line 122 in run
File "/home/runner/work/cpython/cpython/Lib/unittest/suite.py", line 84 in call
File "/home/runner/work/cpython/cpython/Lib/unittest/runner.py", line 206 in run
File "/home/runner/work/cpython/cpython/Lib/test/support/init.py", line 998 in _run_suite
File "/home/runner/work/cpython/cpython/Lib/test/support/init.py", line 1124 in run_unittest
File "/home/runner/work/cpython/cpython/Lib/test/libregrtest/runtest.py", line 261 in _test_module
File "/home/runner/work/cpython/cpython/Lib/test/libregrtest/runtest.py", line 297 in _runtest_inner2
File "/home/runner/work/cpython/cpython/Lib/test/libregrtest/runtest.py", line 340 in _runtest_inner
File "/home/runner/work/cpython/cpython/Lib/test/libregrtest/runtest.py", line 215 in _runtest
File "/home/runner/work/cpython/cpython/Lib/test/libregrtest/runtest.py", line 245 in runtest
File "/home/runner/work/cpython/cpython/Lib/test/libregrtest/main.py", line 337 in rerun_failed_tests
File "/home/runner/work/cpython/cpython/Lib/test/libregrtest/main.py", line 715 in _main
File "/home/runner/work/cpython/cpython/Lib/test/libregrtest/main.py", line 658 in main
File "/home/runner/work/cpython/cpython/Lib/test/libregrtest/main.py", line 736 in main
File "/home/runner/work/cpython/cpython/Lib/test/main.py", line 2 in
File "/home/runner/work/cpython/cpython/Lib/runpy.py", line 86 in _run_code
File "/home/runner/work/cpython/cpython/Lib/runpy.py", line 196 in _run_module_as_main

bpo-45200

@terryjreedy
Copy link
Member Author

terryjreedy commented Sep 15, 2021

Failures on test run 2.
https://github.com/python/cpython/pull/28344/checks?check_run_id=3606975682

0:02:58 load avg: 2.99 [242/427/1] test__xxsubinterpreters crashed (Exit code 3221225477) -- running: test_mmap (42.3 sec), test_largefile (33.3 sec)

Thread 0x0000178c (most recent call first):

Thread 0x0000178c (most recent call first):
File "D:\a\cpython\cpython\lib\threading.py", line 320 in wait
File "D:\a\cpython\cpython\lib\threading.py", line 600 in wait
File "D:\a\cpython\cpython\lib\threading.py", line 933 in start
File "D:\a\cpython\cpython\lib\test\test__xxsubinterpreters.py", line 798 in test_in_thread
File "D:\a\cpython\cpython\lib\unittest\case.py", line 549 in callTestMethod
File "D:\a\cpython\cpython\lib\unittest\case.py", line 593 in run
File "D:\a\cpython\cpython\lib\unittest\case.py", line 652 in call
File "D:\a\cpython\cpython\lib\unittest\suite.py", line 122 in run
File "D:\a\cpython\cpython\lib\unittest\suite.py", line 84 in call
File "D:\a\cpython\cpython\lib\unittest\suite.py", line 122 in run
File "D:\a\cpython\cpython\lib\unittest\suite.py", line 84 in call
File "D:\a\cpython\cpython\lib\unittest\suite.py", line 122 in run
File "D:\a\cpython\cpython\lib\unittest\suite.py", line 84 in call
File "D:\a\cpython\cpython\lib\unittest\runner.py", line 206 in run
File "D:\a\cpython\cpython\lib\test\support_init
.py", line 998 in run_suite
File "D:\a\cpython\cpython\lib\test\support_init
.py", line 1124 in run_unittest
File "D:\a\cpython\cpython\lib\test\libregrtest\runtest.py", line 261 in _test_module
File "D:\a\cpython\cpython\lib\test\libregrtest\runtest.py", line 297 in _runtest_inner2
File "D:\a\cpython\cpython\lib\test\libregrtest\runtest.py", line 340 in _runtest_inner
File "D:\a\cpython\cpython\lib\test\libregrtest\runtest.py", line 202 in _runtest
File "D:\a\cpython\cpython\lib\test\libregrtest\runtest.py", line 245 in runtest
File "D:\a\cpython\cpython\lib\test\libregrtest\runtest_mp.py", line 83 in run_tests_worker
File "D:\a\cpython\cpython\lib\test\libregrtest\main.py", line 678 in _main
File "D:\a\cpython\cpython\lib\test\libregrtest\main.py", line 658 in main
File "D:\a\cpython\cpython\lib\test\libregrtest\main.py", line 736 in main
File "D:\a\cpython\cpython\lib\test\regrtest.py", line 43 in _main
File "D:\a\cpython\cpython\lib\test\regrtest.py", line 47 in
File "D:\a\cpython\cpython\lib\runpy.py", line 86 in _run_code
File "D:\a\cpython\cpython\lib\runpy.py", line 196 in _run_module_as_main

======================================================================
FAIL: test_sendfile_close_peer_in_the_middle_of_receiving (test.test_asyncio.test_sendfile.ProactorEventLoopTests)

Traceback (most recent call last):
File "D:\a\cpython\cpython\lib\test\test_asyncio\test_sendfile.py", line 457, in test_sendfile_close_peer_in_the_middle_of_receiving
with self.assertRaises(ConnectionError):
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: ConnectionError not raised

@terryjreedy terryjreedy merged commit 369bf94 into python:main Sep 15, 2021
@miss-islington
Copy link
Contributor

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@terryjreedy terryjreedy deleted the nofreeze branch September 15, 2021 07:08
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 15, 2021
Otherwise, test would need special import.
(cherry picked from commit 369bf94)

Co-authored-by: Terry Jan Reedy <[email protected]>
@bedevere-bot
Copy link

GH-28345 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Sep 15, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 15, 2021
Otherwise, test would need special import.
(cherry picked from commit 369bf94)

Co-authored-by: Terry Jan Reedy <[email protected]>
@bedevere-bot
Copy link

GH-28346 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Sep 15, 2021
miss-islington added a commit that referenced this pull request Sep 15, 2021
Otherwise, test would need special import.
(cherry picked from commit 369bf94)

Co-authored-by: Terry Jan Reedy <[email protected]>
miss-islington added a commit that referenced this pull request Sep 15, 2021
Otherwise, test would need special import.
(cherry picked from commit 369bf94)

Co-authored-by: Terry Jan Reedy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants