Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-45101: Add consistency in usage message IO between 2 versions of python-config #28162

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

kiendang
Copy link
Contributor

@kiendang kiendang commented Sep 4, 2021

This PR makes both python and shell script versions of python-config to print out the usage instruction message to

  • stdout when --help is provided
  • stderr when given invalid arguments

following the same behavior in argparse and pkg-config.

https://bugs.python.org/issue45101

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@kiendang

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) February 26, 2024 18:57
auto-merge was automatically disabled February 26, 2024 18:59

Pull Request is not mergeable

@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) February 26, 2024 19:05
@serhiy-storchaka serhiy-storchaka merged commit de2a73d into python:main Feb 26, 2024
22 checks passed
@kiendang kiendang deleted the fix-issue-45101 branch February 27, 2024 03:10
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
…python-config (pythonGH-28162)

On --help output to stdout.
On error output to stderr.
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
…python-config (pythonGH-28162)

On --help output to stdout.
On error output to stderr.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
…python-config (pythonGH-28162)

On --help output to stdout.
On error output to stderr.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants