Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-44967: pydoc: return non-zero exit code when query is not found #27868

Merged
merged 2 commits into from
Aug 26, 2021

Conversation

gpanders
Copy link
Contributor

@gpanders gpanders commented Aug 21, 2021

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@gpanders

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@gpanders gpanders changed the title pydoc: return non-zero exit code when query is not found bpo-44967: pydoc: return non-zero exit code when query is not found Aug 21, 2021
@ambv
Copy link
Contributor

ambv commented Aug 25, 2021

Hi @gpanders, thanks for your contribution! I'm assuming you filled out the CLA and we're waiting for it to clear. In the mean time, your PR will definitely need updated tests and a NEWS entry.

@gpanders
Copy link
Contributor Author

The CLA is signed and I have a test written, but I'm not sure where to put the NEWS file. Misc/NEWS.d/next/Tools-Demos/ seems like the right place, but it looks like the filenames each have some kind of 6 character identifier that I'm unsure how to generate.

@ambv
Copy link
Contributor

ambv commented Aug 26, 2021

It's probably easiest to put a NEWS entry using this app:

https://blurb-it.herokuapp.com/

@gpanders
Copy link
Contributor Author

Thanks! Blurb added.

@ambv ambv merged commit 8868d48 into python:main Aug 26, 2021
@iritkatriel
Copy link
Member

I think this PR may have caused #98374.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants