Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-42255: Deprecate webbrowser.MacOSX from Python 3.11 #27837

Merged
merged 2 commits into from
Sep 3, 2021

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Aug 19, 2021

+------------------------+-----------------------------------------+-------+
| ``'safari'`` | :class:`MacOSX('safari')` | \(3) |
| ``'safari'`` | :class:`MacOSXOSAScript('safari')` | \(3) |
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section should be backported

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can reasonably call renaming MacOSX to MacOSXOSAScript a "backport" of this PR since it is about the deprecation. I'll of course accept PRs to 3.10 and 3.9 that make this doc change.

@@ -143,9 +143,9 @@ for the controller classes, all defined in this module.
+------------------------+-----------------------------------------+-------+
| ``'windows-default'`` | :class:`WindowsDefault` | \(2) |
+------------------------+-----------------------------------------+-------+
| ``'macosx'`` | :class:`MacOSX('default')` | \(3) |
| ``'macosx'`` | :class:`MacOSXOSAScript('default')` | \(3) |
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section should be backported

@corona10 corona10 requested a review from ambv September 1, 2021 03:05
@corona10
Copy link
Member Author

corona10 commented Sep 1, 2021

@ambv Can you please take a look? cc @ned-deily @ronaldoussoren

Copy link
Contributor

@ambv ambv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See PEP 387 for our deprecation policy.

Doc/library/webbrowser.rst Outdated Show resolved Hide resolved
Doc/whatsnew/3.11.rst Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@ambv
Copy link
Contributor

ambv commented Sep 3, 2021

@corona10, please also resolve the conflict with main.

@corona10
Copy link
Member Author

corona10 commented Sep 3, 2021

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@ambv: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from ambv September 3, 2021 13:34
@ambv
Copy link
Contributor

ambv commented Sep 3, 2021

@corona10, your force-push undid the changes to 3.13. I'll make them myself since you had them in a035970b79921a66d29688b3a30e5108af3fa82c.

@ambv ambv merged commit bc1c49f into python:main Sep 3, 2021
@corona10 corona10 deleted the bpo-42255 branch September 3, 2021 16:21
@corona10
Copy link
Member Author

corona10 commented Sep 3, 2021

@ambv Thanks :)
I notice it now that I made mistake while rebased on my local environment :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants