-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-42255: Deprecate webbrowser.MacOSX from Python 3.11 #27837
Conversation
+------------------------+-----------------------------------------+-------+ | ||
| ``'safari'`` | :class:`MacOSX('safari')` | \(3) | | ||
| ``'safari'`` | :class:`MacOSXOSAScript('safari')` | \(3) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section should be backported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we can reasonably call renaming MacOSX to MacOSXOSAScript a "backport" of this PR since it is about the deprecation. I'll of course accept PRs to 3.10 and 3.9 that make this doc change.
@@ -143,9 +143,9 @@ for the controller classes, all defined in this module. | |||
+------------------------+-----------------------------------------+-------+ | |||
| ``'windows-default'`` | :class:`WindowsDefault` | \(2) | | |||
+------------------------+-----------------------------------------+-------+ | |||
| ``'macosx'`` | :class:`MacOSX('default')` | \(3) | | |||
| ``'macosx'`` | :class:`MacOSXOSAScript('default')` | \(3) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section should be backported
@ambv Can you please take a look? cc @ned-deily @ronaldoussoren |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See PEP 387 for our deprecation policy.
Misc/NEWS.d/next/Library/2021-08-19-23-49-10.bpo-42255.ofe3ms.rst
Outdated
Show resolved
Hide resolved
When you're done making the requested changes, leave the comment: |
@corona10, please also resolve the conflict with |
I have made the requested changes; please review again |
Thanks for making the requested changes! @ambv: please review the changes made to this pull request. |
@corona10, your force-push undid the changes to 3.13. I'll make them myself since you had them in a035970b79921a66d29688b3a30e5108af3fa82c. |
@ambv Thanks :) |
https://bugs.python.org/issue42255