Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-42854: Correctly use size_t for _ssl._SSLSocket.read and _ssl._SSLSocket.write #27271

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Jul 20, 2021

Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a bunch of warnings related to signed and unsigned comparison, e.g. comparison of integer expressions of different signedness: ‘size_t’ {aka ‘long unsigned int’} and ‘Py_ssize_t’ {aka ‘long int’} [-Wsign-compare]. Maybe use Py_ssize_t?

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@pablogsal
Copy link
Member Author

pablogsal commented Jul 23, 2021

I'm landing this as there is no compiler warnings anymore and I don't want to commit this very close to the rc.

@pablogsal pablogsal added the needs backport to 3.10 only security fixes label Jul 23, 2021
@pablogsal pablogsal merged commit 83d1430 into python:main Jul 23, 2021
@pablogsal pablogsal deleted the bpo-42854 branch July 23, 2021 15:05
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-27308 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 23, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 23, 2021
…LSocket.write (pythonGH-27271)

(cherry picked from commit 83d1430)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
pablogsal added a commit that referenced this pull request Jul 23, 2021
…LSocket.write (GH-27271) (GH-27308)

(cherry picked from commit 83d1430)

Co-authored-by: Pablo Galindo Salgado <[email protected]>

Co-authored-by: Pablo Galindo Salgado <[email protected]>
@python python deleted a comment from bedevere-bot Jul 23, 2021
tiran added a commit to tiran/cpython that referenced this pull request Aug 3, 2022
tiran added a commit to tiran/cpython that referenced this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants