-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-42854: Correctly use size_t for _ssl._SSLSocket.read and _ssl._SSLSocket.write #27271
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a bunch of warnings related to signed and unsigned comparison, e.g. comparison of integer expressions of different signedness: ‘size_t’ {aka ‘long unsigned int’} and ‘Py_ssize_t’ {aka ‘long int’} [-Wsign-compare]
. Maybe use Py_ssize_t?
When you're done making the requested changes, leave the comment: |
I'm landing this as there is no compiler warnings anymore and I don't want to commit this very close to the rc. |
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
GH-27308 is a backport of this pull request to the 3.10 branch. |
…LSocket.write (pythonGH-27271) (cherry picked from commit 83d1430) Co-authored-by: Pablo Galindo Salgado <[email protected]>
…LSocket.write (GH-27271) (GH-27308) (cherry picked from commit 83d1430) Co-authored-by: Pablo Galindo Salgado <[email protected]> Co-authored-by: Pablo Galindo Salgado <[email protected]>
…_ssl._SSLSocket.write (pythonGH-27271)" This reverts commit 83d1430.
…_ssl._SSLSocket.write (pythonGH-27271)" This reverts commit 83d1430.
https://bugs.python.org/issue42854