bpo-41930: Add support for SQLite serialise/deserialise API #26728
Conversation
erlend-aasland
changed the title
erlend-aasland
force-pushed
the
sqlite-serialize
branch
from
2739573 to
07d3b5c
Compare
Don't return size; use len() on the returned bytes object instead.
Add basic test for this
Regen clinic after pythonGH-27155.
Sync with main bco. pythonGH-27273
Sync with main bco. pythonGH-27431
There was a problem hiding this comment.
Thanks. I'm on board with merging this, since it's generally useful for sqlite3 to expose more of the underlying SQLite API, the feature is simple and shouldn't need much maintenance in the future, and there haven't been any objections on the issue.
I do have a few small comments. Once those are addressed, I'll ask Guido for a second look and then merge the PR.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Jelle Zijlstra <[email protected]>
- adjust docs - deserialize returns None - remove 'non-standard' from docstring
There was a problem hiding this comment.
Looks good! @gvanrossum I'm planning to merge this PR (adding two new functions to sqlite3)
SGTM |
Co-authored-by: Kumar Aditya <[email protected]>
|
FYI: synced with |
|
@JelleZijlstra, will you be able to merge this before todays alpha? |
|
Oops, sorry for dropping this. There are merge conflicts on the configure scripts, could you resolve those? |
|
Thanks, Jelle! |
- Blob from python/cpython#30680 (and anticipating that python/cpython#91550 will be merged) - Aggregate window functions from python/cpython#20903 - Serialize/deserialize from python/cpython#26728 - Limit setting from python/cpython#28463
- Blob from python/cpython#30680 (and anticipating that python/cpython#91550 will be merged) - Aggregate window functions from python/cpython#20903 - Serialize/deserialize from python/cpython#26728 - Limit setting from python/cpython#28463
https://bugs.python.org/issue41930