Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed broken link to PyFLTK #26315

Merged
merged 1 commit into from
May 25, 2021
Merged

Fixed broken link to PyFLTK #26315

merged 1 commit into from
May 25, 2021

Conversation

mark-summerfield
Copy link
Contributor

No description provided.

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label May 23, 2021
Fidget-Spinner
Fidget-Spinner approved these changes May 23, 2021
View reviewed changes
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing the link! I've verified that the new links work.

@Fidget-Spinner Fidget-Spinner added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels May 23, 2021
nanjekyejoannah
nanjekyejoannah reviewed May 25, 2021
View reviewed changes
Copy link
Contributor

@nanjekyejoannah nanjekyejoannah left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just confirmed the current link "http://pyfltk.sourceforge.net" resolves too, i.e it's not broken.
And both links point to the same content, hence no need for this change IMHO.

@Fidget-Spinner
Copy link
Member

I just confirmed the current link "http://pyfltk.sourceforge.net" resolves too, i.e it's not broken.
And both links point to the same content, hence no need for this change IMHO.

Oh yeah you're right. it redirects to the new link.

@mark-summerfield
Copy link
Contributor Author

It didn't redirect when I tried it which is why I reported it broken.

@nanjekyejoannah
Copy link
Contributor

Thanks for reporting this @mark-summerfield but I guess nevertheless, we can just point to the redirected link.

@nanjekyejoannah nanjekyejoannah merged commit ee3d78e into python:main May 25, 2021
@miss-islington
Copy link
Contributor

Thanks @mark-summerfield for the PR, and @nanjekyejoannah for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2021
@mark-summerfield @miss-islington
Point to recent link to PyFLTK (pythonGH-26315)
4281a33 
(cherry picked from commit ee3d78e)

Co-authored-by: Mark <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 25, 2021
@bedevere-bot
Copy link

GH-26366 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2021
@mark-summerfield @miss-islington
Point to recent link to PyFLTK (pythonGH-26315)
36f231d 
(cherry picked from commit ee3d78e)

Co-authored-by: Mark <[email protected]>
@bedevere-bot
Copy link

GH-26367 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label May 25, 2021
nanjekyejoannah pushed a commit that referenced this pull request May 25, 2021
@miss-islington @mark-summerfield
Point to recent link to PyFLTK (GH-26315) (GH-26367)
e7078ee 
(cherry picked from commit ee3d78e)

Co-authored-by: Mark <[email protected]>

Co-authored-by: Mark <[email protected]>
nanjekyejoannah pushed a commit that referenced this pull request May 25, 2021
@miss-islington @mark-summerfield
Point to recent link to PyFLTK (GH-26315) (GH-26366)
2442b34 
(cherry picked from commit ee3d78e)

Co-authored-by: Mark <[email protected]>

Co-authored-by: Mark <[email protected]>
@mark-summerfield mark-summerfield deleted the patch-1 branch May 26, 2021 06:36
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanjekyejoannah nanjekyejoannah nanjekyejoannah approved these changes

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mark-summerfield @Fidget-Spinner @nanjekyejoannah @miss-islington @bedevere-bot @the-knights-who-say-ni