Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StreamHandler.__repr__: ensure that stream.name is a string #2587

Closed
wants to merge 1 commit into from

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Jul 5, 2017

This fixes a TypeError in case the name is a integer.

Ref: pytest-dev/pytest#2555

This fixes a TypeError in case the `name` is a integer.

Ref: pytest-dev/pytest#2555
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@mention-bot
Copy link

@blueyed, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vsajip, @benjaminp and @nnorwitz to be potential reviewers.

@blueyed
Copy link
Contributor Author

blueyed commented Jul 5, 2017

According to pytest-dev/pytest#2555 (comment) is should be a string, and therefore this fix is not needed here.

@blueyed blueyed closed this Jul 5, 2017
@blueyed blueyed deleted the fix-logging-typeerror branch July 5, 2017 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants