bpo-18233: Add internal methods to access peer chain (GH-25467) #25467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiran
force-pushed
the
bpo-18233-internal-chain
branch
2 times, most recently
from
3e7e4ba to
7a6c053
Compare
The internal `_ssl._SSLSocket` object now provides methods to retrieve the peer cert chain and verified cert chain as a list of Certificate objects. Certificate objects have methods to convert the cert to a dict, PEM, or DER (ASN.1). These are private APIs for now. There is a slim chance to stabilize the approach and provide a public API for 3.10. Otherwise I'll provide a stable API in 3.11. Signed-off-by: Christian Heimes <[email protected]>
tiran
force-pushed
the
bpo-18233-internal-chain
branch
from
7a6c053 to
b687814
Compare
tiran
added
the
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
|
refleak failures are cause by test_asyncio timeouts. |
tiran
changed the title
This was referenced Sep 30, 2021
sethmlarson
added a commit
to elastic/elastic-transport-python
that referenced
this pull request
Oct 1, 2021
`SSLObject.get_verified_chain()` and `Certificate.public_bytes()` are private APIs in CPython 3.10. They're not documented anywhere yet but seem to work and we need them for Security on by Default. See: python/cpython#25467
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal
_ssl._SSLSocketobject now provides methods to retrievethe peer cert chain and verified cert chain as a list of Certificate
objects. Certificate objects have methods to convert the cert to a dict,
PEM, or DER (ASN.1).
These are private APIs for now. There is a slim chance to stabilize the
approach and provide a public API for 3.10. Otherwise I'll provide a
stable API in 3.11.
Signed-off-by: Christian Heimes [email protected]
https://bugs.python.org/issue18233