Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-43788: Generate version specific _ssl_data.h #25300

Merged
merged 2 commits into from
Apr 9, 2021

Conversation

tiran
Copy link
Member

@tiran tiran commented Apr 9, 2021

Signed-off-by: Christian Heimes [email protected]

https://bugs.python.org/issue43788

Automerge-Triggered-By: GH:tiran

@stefanrad25

This comment has been minimized.

@stefanrad25

This comment has been minimized.

Copy link
Contributor

@benjaminp benjaminp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is definitely a lot better than parsing the headers

@tiran
Copy link
Member Author

tiran commented Apr 9, 2021

Thanks for the wording fix!

@miss-islington
Copy link
Contributor

@tiran: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 150af75 into python:master Apr 9, 2021
@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Sorry, @tiran, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 150af7543214e1541fa582374502ac1cd70e8eb4 3.9

@miss-islington miss-islington self-assigned this Apr 9, 2021
@miss-islington
Copy link
Contributor

Sorry @tiran, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 150af7543214e1541fa582374502ac1cd70e8eb4 3.8

tiran added a commit to tiran/cpython that referenced this pull request Apr 9, 2021
Signed-off-by: Christian Heimes <[email protected]>

Automerge-Triggered-By: GH:tiran.
(cherry picked from commit 150af75)

Co-authored-by: Christian Heimes <[email protected]>
@bedevere-bot
Copy link

GH-25310 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Apr 9, 2021
tiran added a commit to tiran/cpython that referenced this pull request Apr 9, 2021
Signed-off-by: Christian Heimes <[email protected]>

Automerge-Triggered-By: GH:tiran.
(cherry picked from commit 150af75)

Co-authored-by: Christian Heimes <[email protected]>
@bedevere-bot
Copy link

GH-25311 is a backport of this pull request to the 3.8 branch.

tiran added a commit that referenced this pull request Apr 9, 2021
tiran added a commit that referenced this pull request Apr 9, 2021
tiran added a commit to tiran/cpython that referenced this pull request Jul 1, 2022
davidben added a commit to davidben/cpython that referenced this pull request Dec 6, 2022
…codes

Prior to python#25300, the
make_ssl_data.py script used various tables, exposed in _ssl, to update
the error list.

After that PR, this is no longer used. Moreover, the err_names_to_codes
map isn't used at all. Clean those up. This gets them out of the way if,
in the future, OpenSSL provides an API to do what the code here is doing
directly. (openssl/openssl#19848)
davidben added a commit to davidben/cpython that referenced this pull request Dec 6, 2022
…codes

Prior to python#25300, the
make_ssl_data.py script used various tables, exposed in _ssl, to update
the error list.

After that PR, this is no longer used. Moreover, the err_names_to_codes
map isn't used at all. Clean those up. This gets them out of the way if,
in the future, OpenSSL provides an API to do what the code here is doing
directly. (openssl/openssl#19848)
zooba pushed a commit that referenced this pull request Apr 3, 2023
…H-100063)

Prior to #25300, the
make_ssl_data.py script used various tables, exposed in _ssl, to update
the error list.

After that PR, this is no longer used. Moreover, the err_names_to_codes
map isn't used at all. Clean those up. This gets them out of the way if,
in the future, OpenSSL provides an API to do what the code here is doing
directly. (openssl/openssl#19848)
gaogaotiantian pushed a commit to gaogaotiantian/cpython that referenced this pull request Apr 8, 2023
…codes (pythonGH-100063)

Prior to python#25300, the
make_ssl_data.py script used various tables, exposed in _ssl, to update
the error list.

After that PR, this is no longer used. Moreover, the err_names_to_codes
map isn't used at all. Clean those up. This gets them out of the way if,
in the future, OpenSSL provides an API to do what the code here is doing
directly. (openssl/openssl#19848)
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
…codes (pythonGH-100063)

Prior to python#25300, the
make_ssl_data.py script used various tables, exposed in _ssl, to update
the error list.

After that PR, this is no longer used. Moreover, the err_names_to_codes
map isn't used at all. Clean those up. This gets them out of the way if,
in the future, OpenSSL provides an API to do what the code here is doing
directly. (openssl/openssl#19848)
stratakis pushed a commit to stratakis/cpython that referenced this pull request Mar 11, 2024
mcepl pushed a commit to openSUSE-Python/cpython that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants