-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-43780: Sync with importlib_metadata 3.10 #25297
Conversation
@pablogsal I wanted to highlight this change because it introduces a deprecation. There's a lot of background in python/importlib_metadata#284 and linked issues, but I'm aiming to remove the compatibility wrapper that enables Mapping access on the I've put a lot of work into developing a robust transition with low impact and options for every use-case. I've demonstrated the recommended approach to avoid the deprecation in some high profile libraries including twine and keyring and intend to continue to provide direct support for other high-profile libraries. I'd like to introduce this deprecation for Python 3.10 and in a future I welcome your feedback and questions. |
Will review this as soon as possible. |
I realize I might be able to provide more context. python/importlib_metadata#289 shows the change where the deprecation was introduced (and the change that would need to be backed out to remove the deprecation if needed). Here's how the deprecation implemented here manifests:
It occurs to me looking at those tracebacks the stacklevel may need to be tweaked to improve the error message. |
On further consideration, the stacklevel does look correct:
|
Because #25565 now depends on this change, I'd like to merge it now in order to resolve conflicts and get a clean diff for the subsequent PR. Since the deprecation can be readily disabled, I see no reason to get approval in advance. I'd appreciate Pablo's review if possible, but I won't block on it. |
https://bugs.python.org/issue43780