Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-40642: use file-relative include for initconfig.h in pystate.h #24744

Closed
wants to merge 1 commit into from

Conversation

xry111
Copy link
Contributor

@xry111 xry111 commented Mar 4, 2021

Suggested by Andrew Tomazos in bpo:

This will mean that state.h will find initconfig.h using a file-relative include (as all the other include directives do), instead of relying on the installed Include directory being put in the header search path.

As this include directive is the only one with this property, the benefit of this change would be that the Include folder would be able to be installed in any subdirectory of a search path, rather than requiring its own dedicated one.

This would mean (for example) you could install different versions of the Python headers side by side and then select between them using preprocessor directives - rather than having to switch up global compiler options.

https://bugs.python.org/issue40642

@xry111 xry111 marked this pull request as ready for review March 4, 2021 10:49
@xry111
Copy link
Contributor Author

xry111 commented Apr 3, 2021

ping.

@xry111
Copy link
Contributor Author

xry111 commented Apr 21, 2021

Closing, as this is a dup of #20181 and already nack'ed.

@xry111 xry111 closed this Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants